Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 624403002: Write end-of-block comments. (Closed)

Created:
6 years, 2 months ago by scheglov
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -6 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 1 chunk +38 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/ToFormattedSourceVisitor.java View 3 chunks +17 lines, -4 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 1 chunk +58 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 16 chunks +21 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 6 chunks +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 14 chunks +18 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 5 chunks +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 19 chunks +26 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 37 chunks +123 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 9 chunks +9 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 24 chunks +55 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 4 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 36 chunks +43 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 2 months ago (2014-10-05 17:16:02 UTC) #1
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-05 17:47:06 UTC) #2
scheglov
6 years, 2 months ago (2014-10-05 17:54:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40912 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698