Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: pkg/analyzer/lib/src/generated/constant.dart

Issue 624403002: Write end-of-block comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/ast.dart ('k') | pkg/analyzer/lib/src/generated/element.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/constant.dart
diff --git a/pkg/analyzer/lib/src/generated/constant.dart b/pkg/analyzer/lib/src/generated/constant.dart
index 89a8848485ebb0a14f5f6bfe79fde08e66249f3c..b121892a962931fee5df1e23224b7ba8c5487346 100644
--- a/pkg/analyzer/lib/src/generated/constant.dart
+++ b/pkg/analyzer/lib/src/generated/constant.dart
@@ -611,6 +611,10 @@ class ConstantValueComputer {
// this is what the VM does.
value = builtInDefaultValue;
} else {
+ // The code didn't supply an explicit default. The name doesn't exist in the environment.
+ // The VM would use the built-in default value, but we don't want to do that for analysis
+ // because it's likely to lead to cascading errors. So just leave [value] in the unknown
+ // state.
}
}
return value;
@@ -813,6 +817,7 @@ class ConstantValueComputer {
* @param constant the constant that is not a valid compile-time constant
*/
void _generateCycleError(List<AstNode> constantsInCycle, AstNode constant) {
+ // TODO(brianwilkerson) Implement this.
}
ConstructorElement _getConstructorBase(ConstructorElement constructor) {
« no previous file with comments | « pkg/analyzer/lib/src/generated/ast.dart ('k') | pkg/analyzer/lib/src/generated/element.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698