Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: pkg/analyzer/lib/src/generated/html.dart

Issue 624403002: Write end-of-block comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/error.dart ('k') | pkg/analyzer/lib/src/generated/parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/html.dart
diff --git a/pkg/analyzer/lib/src/generated/html.dart b/pkg/analyzer/lib/src/generated/html.dart
index 457df54a162f27443e25881e91d7ae2bcc1d83d4..1c2a2d82e79c6605ff41285ad22a1e9d736a57ff 100644
--- a/pkg/analyzer/lib/src/generated/html.dart
+++ b/pkg/analyzer/lib/src/generated/html.dart
@@ -192,6 +192,7 @@ abstract class AbstractScanner {
_emitWithOffsetAndLength(TokenType.COMMENT, start, -1);
// Capture <!--> and <!---> as tokens but report an error
if (_tail.length < 7) {
+ // TODO (danrubel): Report invalid HTML comment
}
} else {
// handle a declaration
@@ -204,6 +205,7 @@ abstract class AbstractScanner {
}
_emitWithOffsetAndLength(TokenType.DECLARATION, start, -1);
if (!StringUtilities.endsWithChar(_tail.lexeme, 0x3E)) {
+ // TODO (danrubel): Report missing '>' in directive
}
}
} else if (c == 0x3F) {
@@ -221,6 +223,7 @@ abstract class AbstractScanner {
}
_emitWithOffsetAndLength(TokenType.DIRECTIVE, start, -1);
if (_tail.length < 4) {
+ // TODO (danrubel): Report invalid directive
}
} else if (c == 0x2F) {
_emitWithOffset(TokenType.LT_SLASH, start);
@@ -1279,6 +1282,7 @@ class XmlAttributeNode extends XmlNode {
@override
void visitChildren(XmlVisitor visitor) {
+ // no children to visit
}
}
@@ -1803,6 +1807,7 @@ class XmlParser {
* Report the current token as unexpected
*/
void _reportUnexpectedToken() {
+ // TODO (danrubel): report unexpected token
}
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/error.dart ('k') | pkg/analyzer/lib/src/generated/parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698