Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 619723007: Splits up dependent load in update of allocation stats. (Closed)

Created:
6 years, 2 months ago by zra
Modified:
6 years, 2 months ago
Reviewers:
regis, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Splits up dependent loads in update of allocation stats. Also uses strd for object and array initizlization. Only on ARM for now. Together, these changes reduce the number of profiler ticks in allocation stubs ~20%, and give a small improvement on some benchmarks. R=johnmccutchan@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -149 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +15 lines, -8 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 5 chunks +56 lines, -74 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 3 chunks +31 lines, -20 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 8 chunks +83 lines, -47 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zra
6 years, 2 months ago (2014-10-01 18:21:45 UTC) #2
regis
LGTM
6 years, 2 months ago (2014-10-01 18:46:41 UTC) #3
Cutch
lgtm
6 years, 2 months ago (2014-10-01 19:46:06 UTC) #4
zra
6 years, 2 months ago (2014-10-01 19:47:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r40852 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698