Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: runtime/vm/assembler_arm.h

Issue 619723007: Splits up dependent load in update of allocation stats. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.h
===================================================================
--- runtime/vm/assembler_arm.h (revision 40840)
+++ runtime/vm/assembler_arm.h (working copy)
@@ -800,15 +800,22 @@
return TargetCPUFeatures::store_pc_read_offset();
}
- void UpdateAllocationStats(intptr_t cid,
- Register temp_reg,
- Heap::Space space);
+ // The register into which the allocation stats table is loaded with
+ // LoadAllocationStatsAddress should be passed to
+ // IncrementAllocationStats(WithSize) as stats_addr_reg to update the
+ // allocation stats. These are separate assembler macros so we can
+ // avoid a dependent load too nearby the load of the table address.
+ void LoadAllocationStatsAddress(Register dest,
+ intptr_t cid,
+ Heap::Space space);
+ void IncrementAllocationStats(Register stats_addr,
+ intptr_t cid,
+ Heap::Space space);
+ void IncrementAllocationStatsWithSize(Register stats_addr_reg,
+ Register size_reg,
+ intptr_t cid,
+ Heap::Space space);
- void UpdateAllocationStatsWithSize(intptr_t cid,
- Register size_reg,
- Register temp_reg,
- Heap::Space space);
-
Address ElementAddressForIntIndex(bool is_load,
bool is_external,
intptr_t cid,
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698