Splits up dependent load in update of allocation stats.

runtime/vm/intrinsifier_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 278 matching lines @@
   /* R0: potential new object start. */                                        \
   /* R1: potential next object start. */                                       \
   /* R2: allocation size. */                                                   \
   __ LoadImmediate(R3, heap->EndAddress(space));                               \
   __ ldr(R3, Address(R3, 0));                                                  \
   __ cmp(R1, Operand(R3));                                                     \
   __ b(&fall_through, CS);                                                     \
                                                                                \
   /* Successfully allocated the object(s), now update top to point to */       \
   /* next object start and initialize the object. */                           \
+  __ LoadAllocationStatsAddress(R4, cid, space);                               \
   __ LoadImmediate(R3, heap->TopAddress(space));                               \
   __ str(R1, Address(R3, 0));                                                  \
   __ AddImmediate(R0, kHeapObjectTag);                                         \
-  __ UpdateAllocationStatsWithSize(cid, R2, R4, space);                        \
   /* Initialize the tags. */                                                   \
   /* R0: new object start as a tagged pointer. */                              \
   /* R1: new object end address. */                                            \
   /* R2: allocation size. */                                                   \
+  /* R4: allocation stats address */                                           \
   {                                                                            \
     __ CompareImmediate(R2, RawObject::SizeTag::kMaxSizeTag);                  \
-    __ mov(R2, Operand(R2, LSL,                                                \
+    __ mov(R3, Operand(R2, LSL,                                                \
         RawObject::kSizeTagPos - kObjectAlignmentLog2), LS);                   \
-    __ mov(R2, Operand(0), HI);                                                \
+    __ mov(R3, Operand(0), HI);                                                \
                                                                                \
     /* Get the class index and insert it into the tags. */                     \
     __ LoadImmediate(TMP, RawObject::ClassIdTag::encode(cid));                 \
-    __ orr(R2, R2, Operand(TMP));                                              \
-    __ str(R2, FieldAddress(R0, type_name::tags_offset()));  /* Tags. */       \
+    __ orr(R3, R3, Operand(TMP));                                              \
+    __ str(R3, FieldAddress(R0, type_name::tags_offset()));  /* Tags. */       \
   }                                                                            \
   /* Set the length field. */                                                  \
   /* R0: new object start as a tagged pointer. */                              \
   /* R1: new object end address. */                                            \
-  __ ldr(R2, Address(SP, kArrayLengthStackOffset));  /* Array length. */       \
+  /* R2: allocation size. */                                                   \
+  /* R4: allocation stats address. */                                          \
+  __ ldr(R3, Address(SP, kArrayLengthStackOffset));  /* Array length. */       \
   __ StoreIntoObjectNoBarrier(R0,                                              \
                               FieldAddress(R0, type_name::length_offset()),    \
-                              R2);                                             \
+                              R3);                                             \
   /* Initialize all array elements to 0. */                                    \
   /* R0: new object start as a tagged pointer. */                              \
   /* R1: new object end address. */                                            \
-  /* R2: iterator which initially points to the start of the variable */       \
-  /* R3: scratch register. */                                                  \
+  /* R2: allocation size. */                                                   \
+  /* R3: iterator which initially points to the start of the variable */       \
+  /* R4: allocation stats address */                                           \
+  /* R6, R7: zero. */                                                          \
   /* data area to be initialized. */                                           \
-  __ LoadImmediate(R3, 0);                                                     \
-  __ AddImmediate(R2, R0, sizeof(Raw##type_name) - 1);                         \
+  __ LoadImmediate(R6, 0);                                                     \
+  __ mov(R7, Operand(R6));                                                     \
+  __ AddImmediate(R3, R0, sizeof(Raw##type_name) - 1);                         \
   Label init_loop;                                                             \
   __ Bind(&init_loop);                                                         \
-  __ cmp(R2, Operand(R1));                                                     \
-  __ str(R3, Address(R2, 0), CC);                                              \
-  __ add(R2, R2, Operand(kWordSize), CC);                                      \
+  __ AddImmediate(R3, 2 * kWordSize);                                          \
+  __ cmp(R3, Operand(R1));                                                     \
+  __ strd(R6, Address(R3, -2 * kWordSize), LS);                                \
   __ b(&init_loop, CC);                                                        \
+  __ str(R6, Address(R3, -2 * kWordSize), HI);                                 \
                                                                                \
+  __ IncrementAllocationStatsWithSize(R4, R2, cid, space);                     \
   __ Ret();                                                                    \
   __ Bind(&fall_through);                                                      \
 
 
 static int GetScaleFactor(intptr_t size) {
   switch (size) {
     case 1: return 0;
     case 2: return 1;
     case 4: return 2;
     case 8: return 3;
@@ skipping 1073 matching lines @@
   // R1: potential next object start.
   // R2: allocation size.
   // R3: heap->TopAddress(space).
   __ LoadImmediate(R7, heap->EndAddress(space));
   __ ldr(R7, Address(R7, 0));
   __ cmp(R1, Operand(R7));
   __ b(&fail, CS);
 
   // Successfully allocated the object(s), now update top to point to
   // next object start and initialize the object.
+  __ LoadAllocationStatsAddress(R4, cid, space);
   __ str(R1, Address(R3, 0));
   __ AddImmediate(R0, kHeapObjectTag);
-  __ UpdateAllocationStatsWithSize(cid, R2, R3, space);
 
   // Initialize the tags.
   // R0: new object start as a tagged pointer.
   // R1: new object end address.
   // R2: allocation size.
+  // R4: allocation stats address.
   {
     const intptr_t shift = RawObject::kSizeTagPos - kObjectAlignmentLog2;
 
     __ CompareImmediate(R2, RawObject::SizeTag::kMaxSizeTag);
-    __ mov(R2, Operand(R2, LSL, shift), LS);
-    __ mov(R2, Operand(0), HI);
+    __ mov(R3, Operand(R2, LSL, shift), LS);
+    __ mov(R3, Operand(0), HI);
 
     // Get the class index and insert it into the tags.
-    // R2: size and bit tags.
+    // R3: size and bit tags.
     __ LoadImmediate(TMP, RawObject::ClassIdTag::encode(cid));
-    __ orr(R2, R2, Operand(TMP));
-    __ str(R2, FieldAddress(R0, String::tags_offset()));  // Store tags.
+    __ orr(R3, R3, Operand(TMP));
+    __ str(R3, FieldAddress(R0, String::tags_offset()));  // Store tags.
   }
 
   // Set the length field using the saved length (R6).
   __ StoreIntoObjectNoBarrier(R0,
                               FieldAddress(R0, String::length_offset()),
                               R6);
   // Clear hash.
   __ LoadImmediate(TMP, 0);
   __ str(TMP, FieldAddress(R0, String::hash_offset()));
+
+  __ IncrementAllocationStatsWithSize(R4, R2, cid, space);
   __ b(ok);
 
   __ Bind(&fail);
   __ b(failure);
 }
 
 
 // Arg0: OneByteString (receiver).
 // Arg1: Start index as Smi.
 // Arg2: End index as Smi.
@@ skipping 186 matching lines @@
   Isolate* isolate = Isolate::Current();
   __ LoadImmediate(R1, reinterpret_cast<uword>(isolate));
   // Set return value to Isolate::current_tag_.
   __ ldr(R0, Address(R1, Isolate::current_tag_offset()));
   __ Ret();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM