Tell the user if the binstub directory is not on their path.

Tell the user if the binstub directory is not on their path.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40662

[Bob Nystrom, 2014-09-24 21:59:05]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2014-09-24 23:11:09]

https://codereview.chromium.org/601933002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (right):

https://codereview.chromium.org/601933002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/global_packages.dart:634:
${log.yellow('Warning:')} Pub installs executables into ${log.bold(binDir)},
which is not on your path.
Long lines. I like using adjacent single-line strings if you have to split stuff
across lines.

https://codereview.chromium.org/601933002/diff/1/sdk/lib/_internal/pub/test/g...
File sdk/lib/_internal/pub/test/global/binstubs/warns_if_not_on_path.dart
(right):

https://codereview.chromium.org/601933002/diff/1/sdk/lib/_internal/pub/test/g...
sdk/lib/_internal/pub/test/global/binstubs/warns_if_not_on_path.dart:46: */
Why are this test and [getEnvironment] commented out?

[Bob Nystrom, 2014-09-24 23:49:16]

Thanks!

https://codereview.chromium.org/601933002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (right):

https://codereview.chromium.org/601933002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/global_packages.dart:634:
${log.yellow('Warning:')} Pub installs executables into ${log.bold(binDir)},
which is not on your path.
On 2014/09/24 23:11:09, nweiz wrote:
> Long lines. I like using adjacent single-line strings if you have to split
stuff
> across lines.

Done.

https://codereview.chromium.org/601933002/diff/1/sdk/lib/_internal/pub/test/g...
File sdk/lib/_internal/pub/test/global/binstubs/warns_if_not_on_path.dart
(right):

https://codereview.chromium.org/601933002/diff/1/sdk/lib/_internal/pub/test/g...
sdk/lib/_internal/pub/test/global/binstubs/warns_if_not_on_path.dart:46: */
On 2014/09/24 23:11:09, nweiz wrote:
> Why are this test and [getEnvironment] commented out?

Oops. Temp copied code. Deleted.

[nweiz, 2014-09-25 00:06:01]

lgtm

[Bob Nystrom, 2014-09-25 00:45:21]

Committed patchset #2 (id:20001) manually as 40662 (presubmit successful).