Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/global_packages.dart

Issue 601933002: Tell the user if the binstub directory is not on their path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise! Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/lib/src/global_packages.dart
diff --git a/sdk/lib/_internal/pub_generated/lib/src/global_packages.dart b/sdk/lib/_internal/pub_generated/lib/src/global_packages.dart
index c09cf612ff1138bafd0305591190f32d2b72534b..897098871b46eda8f9cdd74788659e18dc97178a 100644
--- a/sdk/lib/_internal/pub_generated/lib/src/global_packages.dart
+++ b/sdk/lib/_internal/pub_generated/lib/src/global_packages.dart
@@ -479,6 +479,7 @@ class GlobalPackages {
'which was not found in ${log.bold(package.name)}.');
}
}
+ if (installed.isNotEmpty) _suggestIfNotOnPath(installed);
}
String _createBinStub(Package package, String executable, String script,
{bool overwrite, String snapshot}) {
@@ -552,4 +553,35 @@ $invocation "\$@"
}
}
}
+ void _suggestIfNotOnPath(List<String> installed) {
+ if (Platform.operatingSystem == "windows") {
+ var result = Process.runSync("where", r"\q", [installed.first]);
+ if (result.exitCode == 0) return;
+ var binDir = _binStubDir;
+ if (binDir.startsWith(Platform.environment['APPDATA'])) {
+ binDir =
+ p.join("%APPDATA%", p.relative(binDir, from: Platform.environment['APPDATA']));
+ }
+ log.warning(
+ "${log.yellow('Warning:')} Pub installs executables into "
+ "${log.bold(binDir)}, which is not on your path.\n"
+ "You can fix that by adding that directory to your system's "
+ '"Path" environment variable.\n'
+ 'A web search for "configure windows path" will show you how.');
+ } else {
+ var result = Process.runSync("which", [installed.first]);
+ if (result.exitCode == 0) return;
+ var binDir = _binStubDir;
+ if (binDir.startsWith(Platform.environment['HOME'])) {
+ binDir =
+ p.join("~", p.relative(binDir, from: Platform.environment['HOME']));
+ }
+ log.warning(
+ "${log.yellow('Warning:')} Pub installs executables into "
+ "${log.bold(binDir)}, which is not on your path.\n"
+ "You can fix that by adding this to your shell's config file "
+ "(.bashrc, .bash_profile, etc.):\n" "\n"
+ "\n${log.bold('export PATH="\$PATH":"$binDir"')}\n");
+ }
+ }
}

Powered by Google App Engine
This is Rietveld 408576698