Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: sdk/lib/_internal/pub/test/global/binstubs/does_not_warn_if_no_executables_test.dart

Issue 601933002: Tell the user if the binstub directory is not on their path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise! Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/global/binstubs/does_not_warn_if_no_executables_test.dart
diff --git a/sdk/lib/_internal/pub/test/global/run/runs_script_test.dart b/sdk/lib/_internal/pub/test/global/binstubs/does_not_warn_if_no_executables_test.dart
similarity index 55%
copy from sdk/lib/_internal/pub/test/global/run/runs_script_test.dart
copy to sdk/lib/_internal/pub/test/global/binstubs/does_not_warn_if_no_executables_test.dart
index bfd8bcbffbd242d8dbea10fea0b8ba706bd4d9d7..565e23afbdcc4e7f6d6e9fc5f4cb6f5da53290ba 100644
--- a/sdk/lib/_internal/pub/test/global/run/runs_script_test.dart
+++ b/sdk/lib/_internal/pub/test/global/binstubs/does_not_warn_if_no_executables_test.dart
@@ -2,24 +2,26 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import 'dart:io';
+
+import 'package:path/path.dart' as p;
+import 'package:scheduled_test/scheduled_test.dart';
+
import '../../descriptor.dart' as d;
import '../../test_pub.dart';
main() {
initConfig();
- integration('runs a script in an activated package', () {
+ integration("does not warn if the package has no executables", () {
servePackages((builder) {
builder.serve("foo", "1.0.0", contents: [
d.dir("bin", [
- d.file("script.dart", "main(args) => print('ok');")
+ d.file("script.dart", "main(args) => print('ok \$args');")
])
]);
});
- schedulePub(args: ["global", "activate", "foo"]);
-
- var pub = pubRun(global: true, args: ["foo:script"]);
- pub.stdout.expect("ok");
- pub.shouldExit();
+ schedulePub(args: ["global", "activate", "foo"],
+ output: isNot(contains("is not on your path")));
});
-}
+}

Powered by Google App Engine
This is Rietveld 408576698