Expands the use of Immediate and Operand wrappers.

Expands the use of Immediate and Operand wrappers.

Since Register is an enum type, it is automatically
coerced to integer types when passed as a parameter to
functions expecting an integer argument. This change
expands the use of Immediate and Operand wrappers
for Assembler instructions and macros to avoid this
automatic coercion.

I've also added dummy constructors to Address and
FieldAddress classes to address the same problem,
but in a way that does not increase verbosity,
since Address and FieldAddress are much more
prevalent in the code.

A cleaner solution would involve making Register
no longer coercable to integer types, but this
would likely require many changes to the Assemblers.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40905

[zra, 2014-09-24 04:02:45]

zra@google.com changed reviewers:
+ iposva@google.com, regis@google.com

[Florian Schneider, 2014-09-24 14:11:08]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2014-09-24 14:11:08]

dbc: I would still like to have the cleaner solution - so that we get a
compile-time error for invalid implicit conversions. Otherwise, chances are that
we miss a place by accident.

[regis, 2014-09-24 16:48:02]

LGTM

[Florian Schneider, 2014-09-25 10:34:02]

dbc: as a reviewer, how do I know that you identified all places where invalid
implicit conversion could happen?

https://codereview.chromium.org/593363003/diff/20001/runtime/vm/assembler_mips.h
File runtime/vm/assembler_mips.h (right):

https://codereview.chromium.org/593363003/diff/20001/runtime/vm/assembler_mip...
runtime/vm/assembler_mips.h:53: Address(Register base, Register offset) {
Just declare the constructor without defining it, since it must not be used. It
will result in a linker errror when used accidentally.

[zra, 2014-09-25 17:34:58]

https://codereview.chromium.org/593363003/diff/20001/runtime/vm/assembler_mips.h
File runtime/vm/assembler_mips.h (right):

https://codereview.chromium.org/593363003/diff/20001/runtime/vm/assembler_mip...
runtime/vm/assembler_mips.h:53: Address(Register base, Register offset) {
On 2014/09/25 10:34:02, Florian Schneider wrote:
> Just declare the constructor without defining it, since it must not be used.
It
> will result in a linker errror when used accidentally.

Done.

[Florian Schneider, 2014-09-26 12:36:58]

https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_arm.h
File runtime/vm/assembler_arm.h (right):

https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm.h:291: UNREACHABLE();
Remove definition and just leave declaration here too.

https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_ia32.h
File runtime/vm/assembler_ia32.h (right):

https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_ia3...
runtime/vm/assembler_ia32.h:216: UNREACHABLE();
Remove definition and just leave declaration here too, and all other places...

[Florian Schneider, 2014-09-26 12:38:06]

On 2014/09/26 12:36:58, Florian Schneider wrote:
>
https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_arm.h
> File runtime/vm/assembler_arm.h (right):
> 
>
https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_arm...
> runtime/vm/assembler_arm.h:291: UNREACHABLE();
> Remove definition and just leave declaration here too.
> 
>
https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_ia32.h
> File runtime/vm/assembler_ia32.h (right):
> 
>
https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_ia3...
> runtime/vm/assembler_ia32.h:216: UNREACHABLE();
> Remove definition and just leave declaration here too, and all other places...

Also, with my change making Register a struct, there would be no need for these
dummy constructors at all.

[zra, 2014-09-26 17:11:36]

https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_arm.h
File runtime/vm/assembler_arm.h (right):

https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_arm...
runtime/vm/assembler_arm.h:291: UNREACHABLE();
On 2014/09/26 12:36:58, Florian Schneider wrote:
> Remove definition and just leave declaration here too.

Done.

https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_ia32.h
File runtime/vm/assembler_ia32.h (right):

https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_ia3...
runtime/vm/assembler_ia32.h:216: UNREACHABLE();
On 2014/09/26 12:36:58, Florian Schneider wrote:
> Remove definition and just leave declaration here too, and all other places...

Done.

[zra, 2014-10-03 19:45:53]

On 2014/09/26 17:11:36, zra wrote:
>
https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_arm.h
> File runtime/vm/assembler_arm.h (right):
> 
>
https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_arm...
> runtime/vm/assembler_arm.h:291: UNREACHABLE();
> On 2014/09/26 12:36:58, Florian Schneider wrote:
> > Remove definition and just leave declaration here too.
> 
> Done.
> 
>
https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_ia32.h
> File runtime/vm/assembler_ia32.h (right):
> 
>
https://codereview.chromium.org/593363003/diff/40001/runtime/vm/assembler_ia3...
> runtime/vm/assembler_ia32.h:216: UNREACHABLE();
> On 2014/09/26 12:36:58, Florian Schneider wrote:
> > Remove definition and just leave declaration here too, and all other
places...
> 
> Done.

I'm going to go ahead and commit this. Further expanding use of the wrappers, or
going with Florian's change in addition, can be made in subsequent changes
without conflicts.

[zra, 2014-10-03 19:46:39]

Committed patchset #5 (id:80001) manually as r40905 (presubmit successful).