Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: runtime/vm/assembler_ia32.h

Issue 593363003: Expands the use of Immediate and Operand wrappers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm_test.cc ('k') | runtime/vm/assembler_mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.h
===================================================================
--- runtime/vm/assembler_ia32.h (revision 40903)
+++ runtime/vm/assembler_ia32.h (working copy)
@@ -165,6 +165,9 @@
SetDisp32(disp);
}
+ // This addressing mode does not exist.
+ Address(Register index, ScaleFactor scale, Register r);
+
Address(Register base, Register index, ScaleFactor scale, int32_t disp) {
ASSERT(index != ESP); // Illegal addressing mode.
if (disp == 0 && base != EBP) {
@@ -181,6 +184,9 @@
}
}
+ // This addressing mode does not exist.
+ Address(Register base, Register index, ScaleFactor scale, Register r);
+
Address(const Address& other) : Operand(other) { }
Address& operator=(const Address& other) {
@@ -205,9 +211,15 @@
FieldAddress(Register base, int32_t disp)
: Address(base, disp - kHeapObjectTag) { }
+ // This addressing mode does not exist.
+ FieldAddress(Register base, Register r);
+
FieldAddress(Register base, Register index, ScaleFactor scale, int32_t disp)
: Address(base, index, scale, disp - kHeapObjectTag) { }
+ // This addressing mode does not exist.
+ FieldAddress(Register base, Register index, ScaleFactor scale, Register r);
+
FieldAddress(const FieldAddress& other) : Address(other) { }
FieldAddress& operator=(const FieldAddress& other) {
« no previous file with comments | « runtime/vm/assembler_arm_test.cc ('k') | runtime/vm/assembler_mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698