Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 592123002: Move SourceReference, extract duplicate code. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move SourceReference, extract duplicate code. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -176 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart View 2 chunks +79 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename.dart View 6 chunks +24 lines, -86 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 3 chunks +8 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 2 chunks +8 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_label.dart View 2 chunks +3 lines, -13 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_library.dart View 2 chunks +5 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_local.dart View 1 chunk +3 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart View 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-22 16:35:30 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-22 16:46:53 UTC) #2
scheglov
6 years, 3 months ago (2014-09-22 17:06:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40550 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698