Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

Issue 592123002: Move SourceReference, extract duplicate code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
index 21f58e511ed4a28a134edd7a117dc9566f6a5937..c62d5647f967d99481ccd252c05065ce4fe6a9e6 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
@@ -8,12 +8,13 @@ import 'dart:async';
import 'package:analysis_server/src/protocol.dart' hide Element;
import 'package:analysis_server/src/services/correction/status.dart';
-import 'package:analysis_server/src/services/refactoring/refactoring.dart';
-import 'package:analysis_server/src/services/search/hierarchy.dart';
-import 'package:analysis_server/src/services/search/search_engine.dart';
import 'package:analysis_server/src/services/correction/util.dart';
import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
+import 'package:analysis_server/src/services/refactoring/refactoring.dart';
+import 'package:analysis_server/src/services/refactoring/refactoring_internal.dart';
import 'package:analysis_server/src/services/refactoring/rename.dart';
+import 'package:analysis_server/src/services/search/hierarchy.dart';
+import 'package:analysis_server/src/services/search/search_engine.dart';
import 'package:analyzer/src/generated/element.dart';
import 'package:analyzer/src/generated/java_core.dart';
@@ -49,19 +50,16 @@ class RenameConstructorRefactoringImpl extends RenameRefactoringImpl {
}
@override
- Future<SourceChange> createChange() {
- SourceChange change = new SourceChange(refactoringName);
+ Future fillChange() {
String replacement = newName.isEmpty ? '' : '.${newName}';
// update references
- return searchEngine.searchReferences(element).then((refMatches) {
- List<SourceReference> references = getSourceReferences(refMatches);
+ return searchEngine.searchReferences(element).then((matches) {
+ List<SourceReference> references = getSourceReferences(matches);
if (!element.isSynthetic) {
for (SourceReference reference in references) {
- SourceEdit edit = createReferenceEdit(reference, replacement);
- change.addElementEdit(reference.element, edit);
+ reference.addEdit(change, replacement);
}
}
- return change;
});
}

Powered by Google App Engine
This is Rietveld 408576698