pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart - Issue 592123002: Move SourceReference, extract duplicate code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

Issue 592123002: Move SourceReference, extract duplicate code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/move_file.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

index 00fc6673b9fe3df5af53998383ed319df835320c..7a63d3189e109fed64f35a011ee110cf3b08ee4f 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

@@ -11,7 +11,6 @@ import 'package:analysis_server/src/services/correction/source_range.dart';

import 'package:analysis_server/src/services/correction/status.dart';

import 'package:analysis_server/src/services/refactoring/refactoring.dart';

import 'package:analysis_server/src/services/refactoring/refactoring_internal.dart';

-import 'package:analysis_server/src/services/refactoring/rename.dart';

import 'package:analysis_server/src/services/search/hierarchy.dart';

import 'package:analysis_server/src/services/search/search_engine.dart';

import 'package:analyzer/src/generated/ast.dart';

@@ -116,7 +115,6 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl implements

}

Future _updateElementReferences(Element element) {

- // TODO(scheglov) move SourceReference to refactoring_internal.dart

return searchEngine.searchReferences(element).then((matches) {

List<SourceReference> references = getSourceReferences(matches);

for (SourceReference reference in references) {