Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 583583004: - Prevent flakes in pi_test.dart. (Closed)

Created:
6 years, 3 months ago by Ivan Posva
Modified:
6 years, 3 months ago
Reviewers:
vsm, zra
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

- Prevent flakes in pi_test.dart. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=40443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M tests/lib/math/pi_test.dart View 1 chunk +25 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ivan Posva
6 years, 3 months ago (2014-09-18 16:17:03 UTC) #2
zra
lgtm
6 years, 3 months ago (2014-09-18 16:24:23 UTC) #3
Ivan Posva
Committed patchset #1 (id:1) manually as r40443 (presubmit successful).
6 years, 3 months ago (2014-09-18 16:53:28 UTC) #4
vsm
The dartium bots are breaking on this change.
6 years, 3 months ago (2014-09-18 20:30:50 UTC) #6
Ivan Posva
6 years, 3 months ago (2014-09-18 22:37:40 UTC) #7
Message was sent while issue was closed.
On 2014/09/18 20:30:50, vsm wrote:
> The dartium bots are breaking on this change.

Fixed with https://codereview.chromium.org/581263003.

-Ivan

Powered by Google App Engine
This is Rietveld 408576698