Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: tests/lib/math/pi_test.dart

Issue 583583004: - Prevent flakes in pi_test.dart. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/math/pi_test.dart
===================================================================
--- tests/lib/math/pi_test.dart (revision 40333)
+++ tests/lib/math/pi_test.dart (working copy)
@@ -11,10 +11,33 @@
import "package:expect/expect.dart";
import 'dart:math';
-void main() {
- var seed = new Random().nextInt(1<<16);
+var known_bad_seeds = const [
+ 50051,
+ 55597,
+ 59208
+];
+
+void main(args) {
+ // Select a seed either from the argument passed in or
+ // otherwise a random seed.
+ var seed = -1;
+ if ((args != null) && (args.length > 0)) {
+ seed = int.parse(args[0]);
+ } else {
+ var seed_prng = new Random();
+ while (seed == -1) {
+ seed = seed_prng.nextInt(1<<16);
+ if (known_bad_seeds.contains(seed)) {
+ // Reset seed and try again.
+ seed = -1;
+ }
+ }
+ }
+
+ // Setup the PRNG for the Monte Carlo simulation.
print("pi_test seed: $seed");
var prng = new Random(seed);
+
var outside = 0;
var inside = 0;
for (var i = 0; i < 600000; i++) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698