Issue 58183003: Implement VariableMirror.isConst in the VM and ParameterMirror.isConst in dart2js.

Issue 58183003: Implement VariableMirror.isConst in the VM and ParameterMirror.isConst in dart2js. (Closed)

Created:
7 years, 1 month ago by rmacnak

Modified:
7 years, 1 month ago

Reviewers:
ahe, gbracha, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement VariableMirror.isConst in the VM and ParameterMirror.isConst in dart2js. BUG=http://dartbug.com/14671 R=ahe@google.com, asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=30161

Patch Set 4 : git cl dcommit #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -6 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	tests/lib/mirrors/parameter_is_const_test.dart	View	1 2	1 chunk	+8 lines, -3 lines	0 comments	Download
A	tests/lib/mirrors/variable_is_const_test.dart	View	1 2	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ahe

Everything but the C++ code reviewed and LGTM! https://codereview.chromium.org/58183003/diff/190001/tests/lib/mirrors/parameter_is_const_test.dart File tests/lib/mirrors/parameter_is_const_test.dart (right): https://codereview.chromium.org/58183003/diff/190001/tests/lib/mirrors/parameter_is_const_test.dart#newcode12 tests/lib/mirrors/parameter_is_const_test.dart:12: foo(param) ...

7 years, 1 month ago (2013-11-11 10:23:06 UTC) #4

rmacnak

https://codereview.chromium.org/58183003/diff/190001/tests/lib/mirrors/parameter_is_const_test.dart File tests/lib/mirrors/parameter_is_const_test.dart (right): https://codereview.chromium.org/58183003/diff/190001/tests/lib/mirrors/parameter_is_const_test.dart#newcode12 tests/lib/mirrors/parameter_is_const_test.dart:12: foo(param) {} On 2013/11/11 10:23:07, ahe wrote: > For ...

7 years, 1 month ago (2013-11-11 17:54:21 UTC) #5

rmacnak

7 years, 1 month ago (2013-11-11 17:55:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r30161 (presubmit successful).

Expand Messages | Collapse Messages