Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 58183003: Implement VariableMirror.isConst in the VM and ParameterMirror.isConst in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: git cl dcommit Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 2a02bd8c326f1cad2ae3f702d983d9ae70c78fc2..9ec13b330bfacc7dd596744191fdda1dc18de29c 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -1266,12 +1266,14 @@ class _LocalVariableMirrorImpl extends _LocalDeclarationMirrorImpl
this.owner,
this._type,
this.isStatic,
- this.isFinal)
+ this.isFinal,
+ this.isConst)
: super(reflectee, _s(simpleName));
final DeclarationMirror owner;
final bool isStatic;
final bool isFinal;
+ final bool isConst;
bool get isPrivate => _n(simpleName).startsWith('_');
@@ -1315,7 +1317,9 @@ class _LocalParameterMirrorImpl extends _LocalVariableMirrorImpl
owner,
null, // We override the type.
false, // isStatic does not apply.
- isFinal);
+ isFinal,
+ false // Not const.
+ );
final int _position;
final bool isOptional;
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698