tests/lib/mirrors/parameter_is_const_test.dart - Issue 58183003: Implement VariableMirror.isConst in the VM and ParameterMirror.isConst in dart2js.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/lib/mirrors/parameter_is_const_test.dart

Issue 58183003: Implement VariableMirror.isConst in the VM and ParameterMirror.isConst in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

	5 library test.parameter_is_const;

	6

5 import 'dart:mirrors';	7 import 'dart:mirrors';

6	8

7 import 'package:expect/expect.dart';	9 import 'package:expect/expect.dart';

8	10

9 class Foo {	11 class Class {

	12 foo(param) {}
	ahe 2013/11/11 10:23:07 For completeness, how about adding: foo( const // For completeness, how about adding: foo( const /// 01: compile-time error param) {} rmacnak 2013/11/11 17:54:22 Done. Show quoted text On 2013/11/11 10:23:07, ahe wrote: > For completeness, how about adding: > > foo( > const /// 01: compile-time error > param) {} Done.
10 }	13 }

11	14

12 main() {	15 main() {

13 Expect.stringEquals('Foo', '${new Foo().runtimeType}');	16 MethodMirror mm = reflectClass(Class).declarations[#foo];

14 Expect.stringEquals('foo', MirrorSystem.getName(new Symbol('foo')));	17 Expect.isFalse(mm.parameters.single.isConst);

15 }	18 }

OLD	NEW

« no previous file with comments | « tests/lib/lib.status ('k') | tests/lib/mirrors/variable_is_const_test.dart » ('j') | tests/lib/mirrors/variable_is_const_test.dart » ('J')