Issue 576703004: Send final problems even if 'validateOnly'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 576703004: Send final problems even if 'validateOnly'. (Closed)

Created:
6 years, 3 months ago by scheglov

Modified:
6 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Send final problems even if 'validateOnly'. Also fix for reporting duplicate 'Rename Local' shadowing warnings. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40332

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ServerRefactoring.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_local.dart	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/edit/refactoring_test.dart	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_local_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

scheglov

PTAL I rolled back the "validateOnly" flag use, so we don't perform final validation if ...

6 years, 3 months ago (2014-09-16 17:14:11 UTC) #2

scheglov

6 years, 3 months ago (2014-09-16 17:48:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 40332 (presubmit successful).