Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: pkg/analysis_server/test/edit/refactoring_test.dart

Issue 576703004: Send final problems even if 'validateOnly'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Request expensive validation in 'checkFinalConditions'. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/edit/refactoring_test.dart
diff --git a/pkg/analysis_server/test/edit/refactoring_test.dart b/pkg/analysis_server/test/edit/refactoring_test.dart
index 0b75218bbdcf7db3664e037d7d47803d4991551f..b3c407a900a0f89c66377c21c6cf98a39fb2695b 100644
--- a/pkg/analysis_server/test/edit/refactoring_test.dart
+++ b/pkg/analysis_server/test/edit/refactoring_test.dart
@@ -1002,10 +1002,12 @@ main() {
}
''');
return getRefactoringResult(() {
- return sendRenameRequest('test = 0', 'newName');
+ return sendRenameRequest('test = 0', 'newName', false);
}).then((result) {
+ List<RefactoringProblem> problems = result.finalProblems;
+ expect(problems, hasLength(1));
assertResultProblemsError(
- result.finalProblems,
+ problems,
"Duplicate local variable 'newName'.");
});
}
@@ -1020,7 +1022,6 @@ class _AbstractGetRefactoring_Test extends AbstractAnalysisTest {
void assertResultProblemsError(List<RefactoringProblem> problems,
[String message]) {
RefactoringProblem problem = problems[0];
- expect(problems, hasLength(1));
expect(
problem.severity,
RefactoringProblemSeverity.ERROR,

Powered by Google App Engine
This is Rietveld 408576698