Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: pkg/analysis_server/test/edit/refactoring_test.dart

Issue 576703004: Send final problems even if 'validateOnly'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Request expensive validation in 'checkFinalConditions'. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.edit.refactoring; 5 library test.edit.refactoring;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/src/edit/edit_domain.dart'; 9 import 'package:analysis_server/src/edit/edit_domain.dart';
10 import 'package:analysis_server/src/protocol.dart'; 10 import 'package:analysis_server/src/protocol.dart';
(...skipping 984 matching lines...) Expand 10 before | Expand all | Expand 10 after
995 995
996 test_localVariable_finalCheck_shadowError() { 996 test_localVariable_finalCheck_shadowError() {
997 addTestFile(''' 997 addTestFile('''
998 main() { 998 main() {
999 var newName; 999 var newName;
1000 int test = 0; 1000 int test = 0;
1001 print(test); 1001 print(test);
1002 } 1002 }
1003 '''); 1003 ''');
1004 return getRefactoringResult(() { 1004 return getRefactoringResult(() {
1005 return sendRenameRequest('test = 0', 'newName'); 1005 return sendRenameRequest('test = 0', 'newName', false);
1006 }).then((result) { 1006 }).then((result) {
1007 List<RefactoringProblem> problems = result.finalProblems;
1008 expect(problems, hasLength(1));
1007 assertResultProblemsError( 1009 assertResultProblemsError(
1008 result.finalProblems, 1010 problems,
1009 "Duplicate local variable 'newName'."); 1011 "Duplicate local variable 'newName'.");
1010 }); 1012 });
1011 } 1013 }
1012 } 1014 }
1013 1015
1014 1016
1015 @ReflectiveTestCase() 1017 @ReflectiveTestCase()
1016 class _AbstractGetRefactoring_Test extends AbstractAnalysisTest { 1018 class _AbstractGetRefactoring_Test extends AbstractAnalysisTest {
1017 /** 1019 /**
1018 * Asserts that [problems] has a single ERROR problem. 1020 * Asserts that [problems] has a single ERROR problem.
1019 */ 1021 */
1020 void assertResultProblemsError(List<RefactoringProblem> problems, 1022 void assertResultProblemsError(List<RefactoringProblem> problems,
1021 [String message]) { 1023 [String message]) {
1022 RefactoringProblem problem = problems[0]; 1024 RefactoringProblem problem = problems[0];
1023 expect(problems, hasLength(1));
1024 expect( 1025 expect(
1025 problem.severity, 1026 problem.severity,
1026 RefactoringProblemSeverity.ERROR, 1027 RefactoringProblemSeverity.ERROR,
1027 reason: problem.toString()); 1028 reason: problem.toString());
1028 if (message != null) { 1029 if (message != null) {
1029 expect(problem.message, message); 1030 expect(problem.message, message);
1030 } 1031 }
1031 } 1032 }
1032 1033
1033 /** 1034 /**
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
1124 } 1125 }
1125 1126
1126 @override 1127 @override
1127 void setUp() { 1128 void setUp() {
1128 super.setUp(); 1129 super.setUp();
1129 server.handlers = [new EditDomainHandler(server),]; 1130 server.handlers = [new EditDomainHandler(server),];
1130 createProject(); 1131 createProject();
1131 handler = new EditDomainHandler(server); 1132 handler = new EditDomainHandler(server);
1132 } 1133 }
1133 } 1134 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698