Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 576473003: Split refactoring problems into init, options and final. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, ricow1, lukeechurch_gmail.com
Visibility:
Public.

Description

Split refactoring problems into init, options and final. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -122 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetRefactoringConsumer.java View 2 chunks +12 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/GetRefactoringProcessor.java View 2 chunks +18 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 19 chunks +77 lines, -49 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ExtractMethodInputPage_NEW.java View 1 chunk +4 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ServerExtractLocalRefactoring.java View 1 chunk +4 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ServerExtractMethodRefactoring.java View 1 chunk +4 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ServerRefactoring.java View 5 chunks +21 lines, -12 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ServerRenameRefactoring.java View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analysis_server/doc/api.html View 2 chunks +23 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 3 chunks +11 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 8 chunks +48 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 10 chunks +20 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +16 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +22 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 3 months ago (2014-09-16 03:40:59 UTC) #1
jwren
On 2014/09/16 03:40:59, scheglov wrote: LGTM
6 years, 3 months ago (2014-09-16 06:37:22 UTC) #2
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-16 13:57:23 UTC) #3
scheglov
If we search for B.m, then it should return a.m(1) (and b.m(2) too), but not ...
6 years, 3 months ago (2014-09-16 14:27:12 UTC) #4
scheglov
6 years, 3 months ago (2014-09-16 15:15:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698