Split refactoring problems into init, options and final.

pkg/analysis_server/lib/src/edit/edit_domain.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library edit.domain;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
@@ skipping 141 matching lines @@
  * An object managing a single [Refactoring] instance.
  *
  * The instance is identified by its kind, file, offset and length.
  * It is initialized when the a set of parameters is given for the first time.
  * All subsequent requests are performed on this [Refactoring] instance.
  *
  * Once new set of parameters is received, the previous [Refactoring] instance
  * is invalidated and a new one is created and initialized.
  */
 class _RefactoringManager {
+  static const List<RefactoringProblem> EMPTY_PROBLEM_LIST = const
+      <RefactoringProblem>[
+      ];
+
   final AnalysisServer server;
   final SearchEngine searchEngine;
 
   RefactoringKind kind;
   String file;
   int offset;
   int length;
   Refactoring refactoring;
   HasToJson feedback;
   RefactoringStatus initStatus;
@@ skipping 19 matching lines @@
   bool get _requiresOptions {
     if (refactoring is InlineLocalRefactoring) {
       return false;
     }
     return true;
   }
 
   void getRefactoring(Request request) {
     // prepare for processing the request
     requestId = request.id;
-    result = new EditGetRefactoringResult(<RefactoringProblem>[]);
+    result = new EditGetRefactoringResult(
+        EMPTY_PROBLEM_LIST,
+        EMPTY_PROBLEM_LIST,
+        EMPTY_PROBLEM_LIST);
     // process the request
     var params = new EditGetRefactoringParams.fromRequest(request);
     _init(params.kind, params.file, params.offset, params.length).then((_) {
       if (initStatus.hasFatalError) {
         return _sendResultResponse();
       }
       // set options
       if (_requiresOptions) {
         if (params.options == null) {
           optionsStatus = new RefactoringStatus();
@@ skipping 142 matching lines @@
     initStatus = new RefactoringStatus();
     optionsStatus = new RefactoringStatus();
     finalStatus = new RefactoringStatus();
   }
 
   void _sendResultResponse() {
     if (feedback != null) {
       result.feedback = feedback;
     }
     // set problems
-    {
-      RefactoringStatus status = new RefactoringStatus();
-      status.addStatus(initStatus);
-      status.addStatus(optionsStatus);
-      status.addStatus(finalStatus);
-      result.problems = status.problems;
-    }
+    result.initialProblems = initStatus.problems;
+    result.optionsProblems = optionsStatus.problems;
+    result.finalProblems = finalStatus.problems;
     // send the response
     server.sendResponse(result.toResponse(requestId));
     // done with this request
     requestId = null;
     result = null;
   }
 
   RefactoringStatus _setOptions(EditGetRefactoringParams params) {
     if (refactoring is ExtractLocalRefactoring) {
       ExtractLocalRefactoring extractRefactoring = refactoring;
@@ skipping 23 matching lines @@
     }
     if (refactoring is RenameRefactoring) {
       RenameRefactoring renameRefactoring = refactoring;
       RenameOptions renameOptions = params.options;
       renameRefactoring.newName = renameOptions.newName;
       return renameRefactoring.checkNewName();
     }
     return new RefactoringStatus();
   }
 }