Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/GetRefactoringProcessor.java

Issue 576473003: Split refactoring problems into init, options and final. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/GetRefactoringProcessor.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/GetRefactoringProcessor.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/GetRefactoringProcessor.java
index 637b816975178fe956fe8648c5eea527a043357b..b79f120e78699fe249aeca2e9eb365269d6a8a01 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/GetRefactoringProcessor.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/GetRefactoringProcessor.java
@@ -47,8 +47,13 @@ public class GetRefactoringProcessor extends ResultProcessor {
public void process(String requestId, JsonObject resultObject) {
// problems
- List<RefactoringProblem> problems = RefactoringProblem.fromJsonArray(resultObject.get(
- "problems").getAsJsonArray());
+ List<RefactoringProblem> initialProblems = getRefactoringProblems(
+ resultObject,
+ "initialProblems");
+ List<RefactoringProblem> optionsProblems = getRefactoringProblems(
+ resultObject,
+ "optionsProblems");
+ List<RefactoringProblem> finalProblems = getRefactoringProblems(resultObject, "finalProblems");
// change
SourceChange change = null;
@@ -79,6 +84,16 @@ public class GetRefactoringProcessor extends ResultProcessor {
feedback = RenameFeedback.fromJson(feedbackObject);
}
}
- consumer.computedRefactorings(problems, feedback, change, potentialEdits);
+ consumer.computedRefactorings(
+ initialProblems,
+ optionsProblems,
+ finalProblems,
+ feedback,
+ change,
+ potentialEdits);
+ }
+
+ private List<RefactoringProblem> getRefactoringProblems(JsonObject resultObject, String name) {
+ return RefactoringProblem.fromJsonArray(resultObject.get(name).getAsJsonArray());
}
}

Powered by Google App Engine
This is Rietveld 408576698