Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 561053003: Give fields a model class in the service library. (Closed)

Created:
6 years, 3 months ago by rmacnak
Modified:
6 years, 3 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Give fields a model class in the service library. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=40166

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10198 lines, -9823 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html View 1 2 8 chunks +39 lines, -39 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js View 1 2 779 chunks +4978 lines, -4816 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 1 2 8 chunks +39 lines, -39 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 779 chunks +4978 lines, -4816 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_ref.html View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html View 1 2 3 chunks +26 lines, -26 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/library_view.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/polymer.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/build.log View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/class_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/field_ref.html View 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/field_view.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/field_view.html View 1 3 chunks +26 lines, -26 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/library_view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 1 4 chunks +54 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/contexts_test.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/inbound_references_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/mirror_references_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/string_escaping_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/test/weak_properties_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
6 years, 3 months ago (2014-09-10 23:20:50 UTC) #2
turnidge
lgtm w/ a comment https://codereview.chromium.org/561053003/diff/1/runtime/bin/vmservice/observatory/lib/src/service/object.dart File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/561053003/diff/1/runtime/bin/vmservice/observatory/lib/src/service/object.dart#newcode1724 runtime/bin/vmservice/observatory/lib/src/service/object.dart:1724: @observable var /* Library or ...
6 years, 3 months ago (2014-09-11 16:48:38 UTC) #3
rmacnak
https://codereview.chromium.org/561053003/diff/1/runtime/bin/vmservice/observatory/lib/src/service/object.dart File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/561053003/diff/1/runtime/bin/vmservice/observatory/lib/src/service/object.dart#newcode1724 runtime/bin/vmservice/observatory/lib/src/service/object.dart:1724: @observable var /* Library or Class */ owner; On ...
6 years, 3 months ago (2014-09-11 17:25:59 UTC) #4
rmacnak
6 years, 3 months ago (2014-09-11 17:33:19 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 40166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698