Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/vmservice/observatory/deployed/web/index_devtools.html

Issue 561053003: Give fields a model class in the service library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js ('k') | runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/observatory/deployed/web/index_devtools.html
diff --git a/runtime/bin/vmservice/observatory/deployed/web/index_devtools.html b/runtime/bin/vmservice/observatory/deployed/web/index_devtools.html
index 4fadba06c19e89ad055271ca19aa811e07c29310..4457cec9c2fe066bce22d451677a8c9052065bf6 100644
--- a/runtime/bin/vmservice/observatory/deployed/web/index_devtools.html
+++ b/runtime/bin/vmservice/observatory/deployed/web/index_devtools.html
@@ -12,7 +12,7 @@
<body><script src="packages/web_components/platform.js"></script>
-<!-- unminfied for debugging:
+<!-- unminified for debugging:
<link rel="import" href="src/js/polymer/layout.html">
<script src="src/js/polymer/polymer.concat.js"></script>
-->
@@ -3505,15 +3505,15 @@ hr {
}
</style>
<span>
- <template if="{{ ref['static'] }}">static</template>
- <template if="{{ ref['final'] }}">final</template>
- <template if="{{ ref['const'] }}">const</template>
- <template if="{{ (ref['declaredType'].name == 'dynamic' &amp;&amp;
- !ref['final'] &amp;&amp; !ref['const']) }}">
+ <template if="{{ ref.isStatic] }}">static</template>
+ <template if="{{ ref.isFinal }}">final</template>
+ <template if="{{ ref.isConst }}">const</template>
+ <template if="{{ (ref.declaredType.name == 'dynamic' &amp;&amp;
+ !ref.isFinal &amp;&amp; !ref.isConst) }}">
var
</template>
- <template if="{{ (ref['declaredType'].name != 'dynamic') }}">
- <instance-ref ref="{{ ref['declaredType'] }}"></instance-ref>
+ <template if="{{ (ref.declaredType.name != 'dynamic') }}">
+ <instance-ref ref="{{ ref.declaredType }}"></instance-ref>
</template>
<a on-click="{{ goto }}" title="{{ hoverText }}" _href="{{ url }}">{{ name }}</a>
</span>
@@ -4828,8 +4828,8 @@ hr {
<field-ref ref="{{ field }}"></field-ref>
</div>
<div class="memberValue">
- <template if="{{ field['value'] != null }}">
- <any-service-ref ref="{{ field['value'] }}"></any-service-ref>
+ <template if="{{ field.value != null }}">
+ <any-service-ref ref="{{ field.value }}"></any-service-ref>
</template>
</div>
</div>
@@ -6152,12 +6152,12 @@ hr {
<nav-bar>
<top-nav-menu></top-nav-menu>
<isolate-nav-menu isolate="{{ field.isolate }}"></isolate-nav-menu>
- <template if="{{ field['owner'].type == 'Class' }}">
+ <template if="{{ field.owner.type == 'Class' }}">
<!-- TODO(turnidge): Add library nav menu here. -->
- <class-nav-menu cls="{{ field['owner'] }}"></class-nav-menu>
+ <class-nav-menu cls="{{ field.owner }}"></class-nav-menu>
</template>
- <template if="{{ field['owner'].type == 'Library' }}">
- <library-nav-menu library="{{ field['owner'] }}"></library-nav-menu>
+ <template if="{{ field.owner.type == 'Library' }}">
+ <library-nav-menu library="{{ field.owner }}"></library-nav-menu>
</template>
<nav-menu link="{{ field.link }}" anchor="{{ field.name }}" last="{{ true }}"></nav-menu>
<nav-refresh callback="{{ refresh }}"></nav-refresh>
@@ -6166,15 +6166,15 @@ hr {
<div class="content">
<h1>
- <template if="{{ field['static'] }}">static</template>
- <template if="{{ field['final'] }}">final</template>
- <template if="{{ field['const'] }}">const</template>
- <template if="{{ (field['declaredType'].name == 'dynamic' &amp;&amp;
- !field['final'] &amp;&amp; !field['const']) }}">
+ <template if="{{ field.isStatic }}">static</template>
+ <template if="{{ field.isFinal }}">final</template>
+ <template if="{{ field.isConst }}">const</template>
+ <template if="{{ (field.declaredType.name == 'dynamic' &amp;&amp;
+ !field.isFinal &amp;&amp; !field.isConst) }}">
var
</template>
- <template if="{{ (field['declaredType'].name != 'dynamic') }}">
- {{ field['declaredType'].name }}
+ <template if="{{ (field.declaredType.name != 'dynamic') }}">
+ {{ field.declaredType.name }}
</template>
{{ field.name }}
</h1>
@@ -6182,48 +6182,48 @@ hr {
<div class="memberItem">
<div class="memberName">owner</div>
<div class="memberValue">
- <template if="{{ field['owner'].type == 'Class' }}">
- <class-ref ref="{{ field['owner'] }}"></class-ref>
+ <template if="{{ field.owner.type == 'Class' }}">
+ <class-ref ref="{{ field.owner }}"></class-ref>
</template>
- <template if="{{ field['owner'].type != 'Class' }}">
- <library-ref ref="{{ field['owner'] }}"></library-ref>
+ <template if="{{ field.owner.type != 'Class' }}">
+ <library-ref ref="{{ field.owner }}"></library-ref>
</template>
</div>
</div>
<div class="memberItem">
<div class="memberName">script</div>
<div class="memberValue">
- <script-ref ref="{{ field['script'] }}"></script-ref>
+ <script-ref ref="{{ field.script }}"></script-ref>
</div>
</div>
- <template if="{{ !field['static'] }}">
+ <template if="{{ !field.isStatic }}">
<div class="memberItem" title="The types observed for this field at runtime. Fields that are observed to have a single type at runtime or to never be null may allow for additional optimization.">
<div class="memberName">observed types</div>
<div class="memberValue">
- <template if="{{ field['guardClass'] == 'dynamic' }}">
+ <template if="{{ field.guardClass == 'dynamic' }}">
various
</template>
- <template if="{{ field['guardClass'] == 'unknown' }}">
+ <template if="{{ field.guardClass == 'unknown' }}">
none
</template>
- <template if="{{ field['guardClass'] != 'unknown' &amp;&amp;
- field['guardClass'] != 'dynamic' }}">
- <class-ref ref="{{ field['guardClass'] }}"></class-ref>
- <template if="{{ field['guardNullable'] }}">
+ <template if="{{ field.guardClass != 'unknown' &amp;&amp;
+ field.guardClass != 'dynamic' }}">
+ <class-ref ref="{{ field.guardClass }}"></class-ref>
+ <template if="{{ field.guardNullable }}">
— null observed
</template>
- <template if="{{ !field['guardNullable'] }}">
+ <template if="{{ !field.guardNullable }}">
— null not observed
</template>
</template>
</div>
</div>
</template>
- <template if="{{ field['value'] != null }}">
+ <template if="{{ field.value != null }}">
<div class="memberItem">
<div class="memberName">static value</div>
<div class="memberValue">
- <any-service-ref ref="{{ field['value'] }}"></any-service-ref>
+ <any-service-ref ref="{{ field.value }}"></any-service-ref>
</div>
</div>
</template>
@@ -15877,7 +15877,7 @@ hr {
<field-ref ref="{{ field['decl'] }}"></field-ref>
</div>
<div class="memberValue">
- <any-service-ref ref="{{ field['value'] }}"></any-service-ref>
+ <any-service-ref ref="{{ field.value }}"></any-service-ref>
</div>
</div>
</template>
@@ -16288,8 +16288,8 @@ hr {
<field-ref ref="{{ field }}"></field-ref>
</div>
<div class="memberValue">
- <template if="{{ field['value'] != null }}">
- <any-service-ref ref="{{ field['value'] }}"></any-service-ref>
+ <template if="{{ field.value != null }}">
+ <any-service-ref ref="{{ field.value }}"></any-service-ref>
</template>
</div>
</div>
« no previous file with comments | « runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js ('k') | runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698