runtime/bin/vmservice/observatory/test/contexts_test.dart - Issue 561053003: Give fields a model class in the service library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/test/contexts_test.dart

Issue 561053003: Give fields a model class in the service library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/service/object.dart ('k') | runtime/bin/vmservice/observatory/test/inbound_references_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/test/contexts_test.dart

diff --git a/runtime/bin/vmservice/observatory/test/contexts_test.dart b/runtime/bin/vmservice/observatory/test/contexts_test.dart

index 05ae127e8fe6c825e593e3265cf39ab6d368e2bc..6eda397e1032cfb14d38f6eade2e92e109e8df8c 100644

--- a/runtime/bin/vmservice/observatory/test/contexts_test.dart

+++ b/runtime/bin/vmservice/observatory/test/contexts_test.dart

@@ -52,8 +52,8 @@ var tests = [

(Isolate isolate) =>

isolate.rootLib.load().then((Library lib) {

- ServiceMap field = lib.variables.singleWhere((v) => v.name == 'cleanBlock');

- return field['value'].load().then((Instance block) {

+ Field field = lib.variables.singleWhere((v) => v.name == 'cleanBlock');

+ return field.value.load().then((Instance block) {

expect(block.isClosure, isTrue);

expect(block.closureCtxt.isContext, isTrue);

expect(block.closureCtxt.length, equals(0));

@@ -65,8 +65,8 @@ var tests = [

(Isolate isolate) =>

isolate.rootLib.load().then((Library lib) {

- ServiceMap field = lib.variables.singleWhere((v) => v.name == 'copyingBlock');

- return field['value'].load().then((Instance block) {

+ Field field = lib.variables.singleWhere((v) => v.name == 'copyingBlock');

+ return field.value.load().then((Instance block) {

expect(block.isClosure, isTrue);

expect(block.closureCtxt.isContext, isTrue);

expect(block.closureCtxt.length, equals(1));

@@ -80,8 +80,8 @@ var tests = [

(Isolate isolate) =>

isolate.rootLib.load().then((Library lib) {

- ServiceMap field = lib.variables.singleWhere((v) => v.name == 'fullBlock');

- return field['value'].load().then((Instance block) {

+ Field field = lib.variables.singleWhere((v) => v.name == 'fullBlock');

+ return field.value.load().then((Instance block) {

expect(block.isClosure, isTrue);

expect(block.closureCtxt.isContext, isTrue);

expect(block.closureCtxt.length, equals(1));

@@ -95,8 +95,8 @@ var tests = [

(Isolate isolate) =>

isolate.rootLib.load().then((Library lib) {

- ServiceMap field = lib.variables.singleWhere((v) => v.name == 'fullBlockWithChain');

- return field['value'].load().then((Instance block) {

+ Field field = lib.variables.singleWhere((v) => v.name == 'fullBlockWithChain');

+ return field.value.load().then((Instance block) {

expect(block.isClosure, isTrue);

expect(block.closureCtxt.isContext, isTrue);

expect(block.closureCtxt.length, equals(1));