Avoid false positives when searching for uses of a constructor.

Avoid false positives when searching for uses of a constructor.

Since constructor invocations are statically bound, there's never a
reason to search for potential matches.  Since potential matching is
performed by name, this avoids an enormous number of false positives
in the case where the constructor is unnamed.

BUG=dartbug.com/20869
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40058

[Paul Berry, 2014-09-09 20:12:34]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-09-09 20:45:17]

lgtm w/comments

https://codereview.chromium.org/560553003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/search/element_references.dart (right):

https://codereview.chromium.org/560553003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/search/element_references.dart:34: element is!
ConstructorElement) {
Push this into _isMemberElement.

https://codereview.chromium.org/560553003/diff/1/pkg/analysis_server/test/sea...
File pkg/analysis_server/test/search/element_references_test.dart (right):

https://codereview.chromium.org/560553003/diff/1/pkg/analysis_server/test/sea...
pkg/analysis_server/test/search/element_references_test.dart:118: new B(2);
Could you add a code that makes the test fail without the fix?

[Paul Berry, 2014-09-09 21:24:59]

https://codereview.chromium.org/560553003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/search/element_references.dart (right):

https://codereview.chromium.org/560553003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/search/element_references.dart:34: element is!
ConstructorElement) {
On 2014/09/09 20:45:17, scheglov wrote:
> Push this into _isMemberElement.

Done.

https://codereview.chromium.org/560553003/diff/1/pkg/analysis_server/test/sea...
File pkg/analysis_server/test/search/element_references_test.dart (right):

https://codereview.chromium.org/560553003/diff/1/pkg/analysis_server/test/sea...
pkg/analysis_server/test/search/element_references_test.dart:118: new B(2);
On 2014/09/09 20:45:17, scheglov wrote:
> Could you add a code that makes the test fail without the fix?

Done.

[Paul Berry, 2014-09-09 21:25:21]

Committed patchset #1 manually as 40058 (presubmit successful).