Avoid false positives when searching for uses of a constructor.

pkg/analysis_server/lib/src/search/element_references.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library search.element_references;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/collections.dart';
 import 'package:analysis_server/src/protocol.dart' show SearchResult;
@@ skipping 12 matching lines @@
   ElementReferencesComputer(this.searchEngine);
 
   /**
    * Computes [SearchResult]s for [element] references.
    */
   Future<List<SearchResult>> compute(Element element, bool withPotential) {
     var futureGroup = new _ConcatFutureGroup<SearchResult>();
     // find element references
     futureGroup.add(_findElementsReferences(element));
     // add potential references
-    if (withPotential && _isMemberElement(element)) {
+    if (withPotential && _isMemberElement(element) &&
+        element is! ConstructorElement) {

[scheglov, 2014/09/09 20:45:17]

Push this into _isMemberElement.

[Paul Berry, 2014/09/09 21:24:59]

Done.

       String name = element.displayName;
       var matchesFuture = searchEngine.searchMemberReferences(name);
       var resultsFuture = matchesFuture.then((List<SearchMatch> matches) {
         return matches.where((match) => !match.isResolved).map(toResult);
       });
       futureGroup.add(resultsFuture);
     }
     // merge results
     return futureGroup.future;
   }
@@ skipping 95 matching lines @@
    * Adds a [Future] or an [E] value to results.
    */
   void add(value) {
     if (value is Future) {
       _futures.add(value);
     } else {
       _futures.add(new Future.value(<E>[value]));
     }
   }
 }