Avoid false positives when searching for uses of a constructor.

pkg/analysis_server/test/search/element_references_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.search.element_references;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import '../reflective_tests.dart';
@@ skipping 42 matching lines @@
   new A.named(2);
 }
 ''');
     return findElementReferences('named(p)', false).then((_) {
       expect(searchElement.kind, ElementKind.CONSTRUCTOR);
       assertHasResult(SearchResultKind.REFERENCE, '.named(1)', 6);
       assertHasResult(SearchResultKind.REFERENCE, '.named(2)', 6);
     });
   }
 
-  test_constructor_unamed() {
+  test_constructor_named_potential() {
+    // Constructors in other classes shouldn't be considered potential matches,
+    // nor should unresolved method calls, since constructor call sites are
+    // statically bound to their targets).
+    addTestFile('''
+class A {
+  A.named(p); // A
+}
+class B {
+  B.named(p);
+}
+f(x) {
+  new A.named(1);
+  new B.named(2);
+  x.named(3);
+}
+''');
+    return findElementReferences('named(p); // A', true).then((_) {
+      expect(searchElement.kind, ElementKind.CONSTRUCTOR);
+      assertHasResult(SearchResultKind.DECLARATION, '.named(p)', 6);
+      assertHasResult(SearchResultKind.REFERENCE, '.named(1)', 6);
+      expect(results, hasLength(2));
+    });
+  }
+
+  test_constructor_unnamed() {
     addTestFile('''
 class A {
   A(p);
 }
 main() {
   new A(1);
   new A(2);
 }
 ''');
     return findElementReferences('A(p)', false).then((_) {
       expect(searchElement.kind, ElementKind.CONSTRUCTOR);
       assertHasResult(SearchResultKind.REFERENCE, '(1)', 0);
       assertHasResult(SearchResultKind.REFERENCE, '(2)', 0);
     });
   }
 
+  test_constructor_unnamed_potential() {
+    // Constructors in other classes shouldn't be considered potential matches,
+    // even if they are also unnamed (since constructor call sites are
+    // statically bound to their targets).
+    addTestFile('''
+class A {
+  A(p); // A
+}
+class B {
+  B(p);
+}
+main() {
+  new A(1);
+  new B(2);

[scheglov, 2014/09/09 20:45:17]

Could you add a code that makes the test fail without the fix?

[Paul Berry, 2014/09/09 21:24:59]

Done.

+}
+''');
+    return findElementReferences('A(p)', true).then((_) {
+      expect(searchElement.kind, ElementKind.CONSTRUCTOR);
+      assertHasResult(SearchResultKind.DECLARATION, '(p); // A', 0);
+      assertHasResult(SearchResultKind.REFERENCE, '(1)', 0);
+      expect(results, hasLength(2));
+    });
+  }
+
   test_field_explicit() {
     addTestFile('''
 class A {
   var fff; // declaration
   A(this.fff); // in constructor
   m() {
     fff = 2;
     fff += 3;
     print(fff); // in m()
     fff(); // in m()
@@ skipping 500 matching lines @@
 }
 ''');
     return findElementReferences('T> {', false).then((_) {
       expect(searchElement.kind, ElementKind.TYPE_PARAMETER);
       expect(results, hasLength(2));
       assertHasResult(SearchResultKind.REFERENCE, 'T f;');
       assertHasResult(SearchResultKind.REFERENCE, 'T m()');
     });
   }
 }