update polymer js to 0.4.0

update polymer js to 0.4.0

BUG= http://dartbug.com/20809

The following files were not migrated, they used to be in platform.js
and are like polyfills, but are adding non-html spec functionality used
by polymer:

src/declaration/mdv.js
src/declaration/polymer.js
src/declaration/queue.js
src/declaration/styles.js
src/lib/dom.js
src/lib/lang.js
src/lib/loader.js
src/lib/styleloader.js
src/lib/url.js
src/system/compat.js
src/system/microtask.js
src/system/module.js
src/system/patches-mdv.js
src/system/unresolved.js

The following tests were not migrated. For the most part they are just
testing the features added by the files above:

test/html/loader-deduplicate.html
test/html/mdv-shadow.html
test/html/mdv-tests/polymer-expressions-tests.js
test/html/styling/recursive-style-import.html
test/html/url.html
test/js/bindMDV.js
test/js/oop.js
test/html/styling/rules/*
test/js/styling.js
test/js/register.js
test/js/utils.js
test/html/template-repeat-wrappers.html

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40120

[jakemac, 2014-09-09 16:39:57]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2014-09-09 21:21:43]

Very nice! just really minor details below. LGTM

https://codereview.chromium.org/558673004/diff/1/pkg/polymer/lib/src/js/polym...
File pkg/polymer/lib/src/js/polymer/build.log (right):

https://codereview.chromium.org/558673004/diff/1/pkg/polymer/lib/src/js/polym...
pkg/polymer/lib/src/js/polymer/build.log:29: polymer-dev:
d66a86eac545ff8115f781ec6b1466024f49c0c0
seems like now that things moved into polymer, we should have additional lines
here. Could we add the rest as well?

I sent a pull request already for platform-dev:
https://github.com/Polymer/platform-dev/pull/47, let's do a similar one for
polymer-dev

https://codereview.chromium.org/558673004/diff/1/pkg/polymer/test/platform_le...
File pkg/polymer/test/platform_less_test.dart (right):

https://codereview.chromium.org/558673004/diff/1/pkg/polymer/test/platform_le...
pkg/polymer/test/platform_less_test.dart:43: if ((htmlImports == null ||
htmlImports['useNative'] != true) ||
could we simply do:


if (ShadowRoot.supported || LinkElement.supportsImport) return;
expect(elementsReadied, 2, reason: 'imported elements upgraded');

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/pubspec...
File pkg/template_binding/pubspec.yaml (right):

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/pubspec...
pkg/template_binding/pubspec.yaml:10: web_components: ">=0.7.0-dev <0.8.0"
should we revert this? (move back as dev_dependency only?)

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/test/cu...
File pkg/template_binding/test/custom_element_bindings_test.html (right):

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/test/cu...
pkg/template_binding/test/custom_element_bindings_test.html:19: <!--<script
src="/packages/polymer/src/js/polymer/polymer.concat.js"></script>-->
delete line

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/test/te...
File pkg/template_binding/test/template_binding_test.dart (right):

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/test/te...
pkg/template_binding/test/template_binding_test.dart:1374: // MutationObserver
here to detect the change to "ref".
what if we use endOfMicrotask instead? or is that too soon?

https://codereview.chromium.org/558673004/diff/1/pkg/web_components/lib/build...
File pkg/web_components/lib/build.log (right):

https://codereview.chromium.org/558673004/diff/1/pkg/web_components/lib/build...
pkg/web_components/lib/build.log:28: platform-dev:
5a7353db53048b8ab4caa6279a56de7d1097d824
let's apply patch #47 so we can get the commit# for URL too.

[jakemac, 2014-09-10 16:30:00]

https://codereview.chromium.org/558673004/diff/1/pkg/polymer/lib/src/js/polym...
File pkg/polymer/lib/src/js/polymer/build.log (right):

https://codereview.chromium.org/558673004/diff/1/pkg/polymer/lib/src/js/polym...
pkg/polymer/lib/src/js/polymer/build.log:29: polymer-dev:
d66a86eac545ff8115f781ec6b1466024f49c0c0
On 2014/09/09 21:21:43, Siggi Cherem (dart-lang) wrote:
> seems like now that things moved into polymer, we should have additional lines
> here. Could we add the rest as well?
> 
> I sent a pull request already for platform-dev:
> https://github.com/Polymer/platform-dev/pull/47, let's do a similar one for
> polymer-dev

Done.

https://codereview.chromium.org/558673004/diff/1/pkg/polymer/test/platform_le...
File pkg/polymer/test/platform_less_test.dart (right):

https://codereview.chromium.org/558673004/diff/1/pkg/polymer/test/platform_le...
pkg/polymer/test/platform_less_test.dart:43: if ((htmlImports == null ||
htmlImports['useNative'] != true) ||
On 2014/09/09 21:21:43, Siggi Cherem (dart-lang) wrote:
> could we simply do:
> 
> 
> if (ShadowRoot.supported || LinkElement.supportsImport) return;
> expect(elementsReadied, 2, reason: 'imported elements upgraded');

done, nice

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/pubspec...
File pkg/template_binding/pubspec.yaml (right):

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/pubspec...
pkg/template_binding/pubspec.yaml:10: web_components: ">=0.7.0-dev <0.8.0"
On 2014/09/09 21:21:43, Siggi Cherem (dart-lang) wrote:
> should we revert this? (move back as dev_dependency only?)

This is kind of a weird one, but I think its important to enforce the version
here even though its not directly used. The reason is if you want to use this
package, you need that specific version of platform.js plus the additional
polyfills under src/js from this package.

Technically, they could use an older version and then not include the polyfills
under src/js, but thats really confusing.

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/test/cu...
File pkg/template_binding/test/custom_element_bindings_test.html (right):

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/test/cu...
pkg/template_binding/test/custom_element_bindings_test.html:19: <!--<script
src="/packages/polymer/src/js/polymer/polymer.concat.js"></script>-->
On 2014/09/09 21:21:43, Siggi Cherem (dart-lang) wrote:
> delete line

Done.

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/test/te...
File pkg/template_binding/test/template_binding_test.dart (right):

https://codereview.chromium.org/558673004/diff/1/pkg/template_binding/test/te...
pkg/template_binding/test/template_binding_test.dart:1374: // MutationObserver
here to detect the change to "ref".
On 2014/09/09 21:21:43, Siggi Cherem (dart-lang) wrote:
> what if we use endOfMicrotask instead? or is that too soon?

I think its best to keep this in sync with the js side, it sounds like they were
having issues with their version of endOfMicrotask so that is why they changed
it here.

https://codereview.chromium.org/558673004/diff/1/pkg/web_components/lib/build...
File pkg/web_components/lib/build.log (right):

https://codereview.chromium.org/558673004/diff/1/pkg/web_components/lib/build...
pkg/web_components/lib/build.log:28: platform-dev:
5a7353db53048b8ab4caa6279a56de7d1097d824
On 2014/09/09 21:21:43, Siggi Cherem (dart-lang) wrote:
> let's apply patch #47 so we can get the commit# for URL too.

Done.

[Siggi Cherem (dart-lang), 2014-09-10 21:05:24]

lgtm

[jakemac, 2014-09-10 21:42:08]

Committed patchset #2 (id:10001) manually as 40120 (presubmit successful).