Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: pkg/polymer/lib/src/loader.dart

Issue 558673004: update polymer js to 0.4.0 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: review updates Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/js/polymer/polymer.js.map ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/loader.dart
diff --git a/pkg/polymer/lib/src/loader.dart b/pkg/polymer/lib/src/loader.dart
index ceeba6cf70f0d25f298599fb604030dfa6dc8cd1..772d54df2cee9397b49e67a8d46bd7ab2238d9d8 100644
--- a/pkg/polymer/lib/src/loader.dart
+++ b/pkg/polymer/lib/src/loader.dart
@@ -87,19 +87,6 @@ void configureForDeployment(List<Function> initializers) {
/// * if it has a Dart class, run PolymerDeclaration's register.
/// * otherwise it is a JS prototype, run polymer-element's normal register.
void _hookJsPolymer() {
- // Note: platform.js is not used directly here, but we check that it is loaded
- // to provide a good error message in Dartium if people forgot to include it.
- // Otherwise, polymer.js below will fail with a hard to understand error
- // message.
- var platform = js.context['Platform'];
- if (platform == null) {
- throw new StateError('platform.js, dart_support.js must be loaded at'
- ' the top of your application, before any other scripts or HTML'
- ' imports that use polymer. Putting these two script tags at the top of'
- ' your <head> element should address this issue:'
- ' <script src="packages/web_components/platform.js"></script> and '
- ' <script src="packages/web_components/dart_support.js"></script>.');
- }
var polymerJs = js.context['Polymer'];
if (polymerJs == null) {
throw new StateError('polymer.js must be loaded before polymer.dart, please'
@@ -155,6 +142,7 @@ JsObject _polymerElementProto = () {
void _initializeLogging() {
hierarchicalLoggingEnabled = true;
var logFlags = js.context['logFlags'];
+ if (logFlags == null) logFlags = {};
var loggers =
[_observeLog, _eventsLog, _unbindLog, _bindLog, _watchLog, _readyLog];
var polymerLogger = new Logger('polymer');
« no previous file with comments | « pkg/polymer/lib/src/js/polymer/polymer.js.map ('k') | pkg/polymer/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698