Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: pkg/polymer/lib/src/instance.dart

Issue 558673004: update polymer js to 0.4.0 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: review updates Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/declaration.dart ('k') | pkg/polymer/lib/src/js/polymer/build.log » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/instance.dart
diff --git a/pkg/polymer/lib/src/instance.dart b/pkg/polymer/lib/src/instance.dart
index c9d5adea2d321aad19278e217e974aa89f8c2f79..37a43ea8ed60effa1947b61e336cb1831505874f 100644
--- a/pkg/polymer/lib/src/instance.dart
+++ b/pkg/polymer/lib/src/instance.dart
@@ -643,6 +643,8 @@ abstract class Polymer implements Element, Observable, NodeBindExtension {
/// You can override this method to change the instantiation behavior of the
/// template, for example to use a different data-binding syntax.
DocumentFragment instanceTemplate(Element template) {
+ // ensure template is decorated (lets things like <tr template ...> work)
+ TemplateBindExtension.decorate(template);
var syntax = this.syntax;
var t = templateBind(template);
if (syntax == null && t.bindingDelegate == null) {
@@ -843,12 +845,12 @@ abstract class Polymer implements Element, Observable, NodeBindExtension {
closeNamedObserver('${name}__array');
}
- // if the new value is an array, being observing it
+ // if the new value is an array, begin observing it
if (value is ObservableList) {
_observeLog.fine(() => '[$_name] observeArrayValue: register $name');
var sub = value.listChanges.listen((changes) {
for (var callback in callbacks) {
- smoke.invoke(this, callback, [old], adjust: true);
+ smoke.invoke(this, callback, [changes], adjust: true);
}
});
registerNamedObserver('${name}__array', sub);
« no previous file with comments | « pkg/polymer/lib/src/declaration.dart ('k') | pkg/polymer/lib/src/js/polymer/build.log » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698