Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552533004: Blink uses types in resolvers and entry points (Closed)

Created:
6 years, 3 months ago by Leaf
Modified:
6 years, 3 months ago
Reviewers:
vsm, terry
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Blink uses types in entry points This CL changes the way that blink entry points are named to use the type signature uniformly. This makes us somewhat more robust against changes in the idl. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=40006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7280 lines, -7337 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 31 chunks +3522 lines, -3620 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 477 chunks +2458 lines, -2458 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 11 chunks +76 lines, -76 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 113 chunks +712 lines, -712 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 25 chunks +161 lines, -161 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 14 chunks +193 lines, -193 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 7 chunks +14 lines, -14 lines 0 comments Download
M tools/dom/scripts/css_code_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 2 chunks +8 lines, -7 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 16 chunks +107 lines, -67 lines 0 comments Download
M tools/dom/src/blink_native_DOMImplementation.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +14 lines, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_FileReader.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Touch.darttemplate View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Leaf
6 years, 3 months ago (2014-09-08 23:46:46 UTC) #2
vsm
lgtm
6 years, 3 months ago (2014-09-08 23:53:35 UTC) #3
Leaf
6 years, 3 months ago (2014-09-09 00:17:25 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 40006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698