Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 552533004: Blink uses types in resolvers and entry points (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/css_code_generator.py ('k') | tools/dom/scripts/systemnative.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/htmldartgenerator.py
diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py
index 1f2a85d9e2d50fcc2bd2baf92726ea6d76880ca6..2f90c46f69644717b454ecc31687b41025b169ed 100644
--- a/tools/dom/scripts/htmldartgenerator.py
+++ b/tools/dom/scripts/htmldartgenerator.py
@@ -544,12 +544,15 @@ class HtmlDartGenerator(object):
stmts_emitter, call_emitter,
version, signature_index, argument_count):
name = emitter.Format('_create_$VERSION', VERSION=version)
+ arguments = constructor_info.idl_args[signature_index][:argument_count]
if self._dart_use_blink:
- base_name = \
- self.DeriveNativeName(name + 'constructorCallback')
+ type_ids = [p.type.id for p in arguments]
+ base_name, rs = \
+ self.DeriveNativeEntry("constructorCallback", None, type_ids,
+ False)
qualified_name = \
- self.DeriveQualifiedBlinkName(self._interface.id,
- base_name)
+ self.DeriveQualifiedBlinkName(self._interface.id,
+ base_name)
else:
qualified_name = emitter.Format(
'$FACTORY.$NAME',
@@ -559,9 +562,7 @@ class HtmlDartGenerator(object):
FACTORY_NAME=qualified_name,
FACTORY_PARAMS= \
constructor_info.ParametersAsArgumentList(argument_count))
- self.EmitStaticFactoryOverload(
- constructor_info, name,
- constructor_info.idl_args[signature_index][:argument_count])
+ self.EmitStaticFactoryOverload(constructor_info, name, arguments)
def IsOptional(signature_index, argument):
return self.IsConstructorArgumentOptional(argument)
« no previous file with comments | « tools/dom/scripts/css_code_generator.py ('k') | tools/dom/scripts/systemnative.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698