Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 551143003: Issue 20894. Improve navigation regions for 'new Class.named()' expression. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 20894. Improve navigation regions for 'new Class.named()' expression. As we discussed offline. Rename changes will follow. R=brianwilkerson@google.com, paulberry@google.com BUG= https://code.google.com/p/dart/issues/detail?id=20894 Committed: https://code.google.com/p/dart/source/detail?r=40207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -11 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 2 chunks +27 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 5 chunks +23 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-11 23:45:45 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-12 03:29:00 UTC) #2
scheglov
6 years, 3 months ago (2014-09-12 15:52:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40207 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698