Issue 20894. Improve navigation regions for 'new Class.named()' expression.

pkg/analysis_server/test/analysis_notification_navigation_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.analysis.notification.navigation;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol.dart';
-import 'reflective_tests.dart';
 import 'package:unittest/unittest.dart';
 
 import 'analysis_abstract.dart';
+import 'reflective_tests.dart';
 
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(AnalysisNotificationNavigationTest);
 }
 
 
 @ReflectiveTestCase()
 class AnalysisNotificationNavigationTest extends AbstractAnalysisTest {
@@ skipping 11 matching lines @@
       Location location = target.location;
       if (location.file == file &&
           location.offset == offset &&
           location.length == length) {
         testTarget = target;
         return;
       }
     }
     fail(
         'Expected to find target (file=$file; offset=$offset; length=$length) in\n'
-            '${testRegion} in\n' '${regions.join('\n')}');
+            '${testRegion} in\n' '${testTargets.join('\n')}');
   }
 
   void assertHasOperatorRegion(String regionSearch, int regionLength,
       String targetSearch, int targetLength) {
     assertHasRegion(regionSearch, regionLength);
     assertHasTarget(targetSearch, targetLength);
   }
 
   /**
    * Validates that there is a region at the offset of [search] in [testFile].
@@ skipping 204 matching lines @@
 
   test_instanceCreation_implicit() {
     addTestFile('''
 class A {
 }
 main() {
   new A();
 }
 ''');
     return prepareNavigation().then((_) {
-      assertHasRegionString('new A');
+      findRegion(findOffset('new A'), 'new A'.length, true);
       assertHasTarget('A {');
     });
   }
 
   test_instanceCreation_named() {
     addTestFile('''
 class A {
   A.named() {}
 }
 main() {
   new A.named();
 }
 ''');
     return prepareNavigation().then((_) {
-      assertHasRegionString('new A.named');
-      assertHasTarget('named() {}');
+      {
+        findRegion(findOffset('new '), 'new '.length, true);
+        assertHasTarget('named() {}');
+      }
+      {
+        findRegion(findOffset('A.named();'), 'A'.length, true);
+        assertHasTarget('A {');
+      }
+      {
+        findRegion(findOffset('.named();'), '.named'.length, true);
+        assertHasTarget('named() {}');
+      }
     });
   }
 
   test_instanceCreation_unnamed() {
     addTestFile('''
 class A {
   A() {}
 }
 main() {
   new A();
 }
 ''');
     return prepareNavigation().then((_) {
-      assertHasRegionString('new A');
-      assertHasTarget("A() {}", 0);
+      {
+        findRegion(findOffset('new '), 'new '.length, true);
+        assertHasTarget('A() {}', 0);
+      }
+      {
+        findRegion(findOffset('A();'), 'A'.length, true);
+        assertHasTarget('A {');
+      }
     });
   }
 
   test_operator_arithmetic() {
     addTestFile('''
 class A {
   A operator +(other) => null;
   A operator -() => null;
   A operator -(other) => null;
   A operator *(other) => null;
@@ skipping 158 matching lines @@
   test_type_void() {
     addTestFile('''
 void main() {
 }
 ''');
     return prepareNavigation().then((_) {
       assertNoRegionAt('void');
     });
   }
 }