Issue 20894. Improve navigation regions for 'new Class.named()' expression.

pkg/analysis_server/lib/src/computer/computer_navigation.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library computer.navigation;
 
 import 'package:analysis_server/src/protocol.dart' as protocol;
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 
 
 /**
  * A computer for navigation regions in a Dart [CompilationUnit].
  */
 class DartUnitNavigationComputer {
   final CompilationUnit _unit;
 
-  final List<protocol.NavigationRegion> _regions = <protocol.NavigationRegion>[];
+  final List<protocol.NavigationRegion> _regions = <protocol.NavigationRegion>[
+      ];
 
   DartUnitNavigationComputer(this._unit);
 
   /**
    * Returns the computed navigation regions, not `null`.
    */
   List<protocol.NavigationRegion> compute() {
     _unit.accept(new _DartUnitNavigationComputerVisitor(this));
     return new List.from(_regions);
   }
@@ skipping 99 matching lines @@
 
   @override
   visitIndexExpression(IndexExpression node) {
     computer._addRegionForToken(node.rightBracket, node.bestElement);
     return super.visitIndexExpression(node);
   }
 
   @override
   visitInstanceCreationExpression(InstanceCreationExpression node) {
     Element element = node.staticElement;
-    if (element != null && element.isSynthetic) {
-      element = element.enclosingElement;
+    ConstructorName constructorName = node.constructorName;
+    if (element != null && constructorName != null) {
+      ClassElement classElement = element.enclosingElement;
+      if (element.isSynthetic) {
+        element = classElement;
+        computer._addRegion_nodeStart_nodeStart(
+            node,
+            node.argumentList,
+            element);
+      } else {
+        // add region for "type" first, so that it is found before "new "
+        computer._addRegionForNode(constructorName.type, classElement);
+        // "new "
+        computer._addRegion_nodeStart_nodeStart(
+            node,
+            constructorName.type,
+            element);
+        // optional ".name"
+        if (constructorName.period != null) {
+          computer._addRegion_tokenStart_nodeEnd(
+              constructorName.period,
+              constructorName,
+              element);
+        }
+      }
     }
-    computer._addRegion_nodeStart_nodeStart(node, node.argumentList, element);
     return super.visitInstanceCreationExpression(node);
   }
 
   @override
   visitPartDirective(PartDirective node) {
     computer._addRegion_tokenStart_nodeEnd(
         node.keyword,
         node.uri,
         node.element);
     return super.visitPartDirective(node);
@@ skipping 22 matching lines @@
 
   @override
   visitSimpleIdentifier(SimpleIdentifier node) {
     if (node.parent is ConstructorDeclaration) {
     } else {
       computer._addRegionForNode(node, node.bestElement);
     }
     return super.visitSimpleIdentifier(node);
   }
 }