Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 542323003: Search domain implementation in the Remote java server, using generated types. (Closed)

Created:
6 years, 3 months ago by jwren
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1, Brian Wilkerson
Visibility:
Public.

Description

Search domain implementation in the Remote java server, using generated types. TypeHierarchyContentProvider_NEW.java functionality has been stubbed out as it is currently written to support the old implementation of the TypeHierarchyItem type. Search functionality in Editor has been converted. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39949

Patch Set 1 #

Patch Set 2 : Remove some now unused classes #

Total comments: 1

Patch Set 3 : rebase with bleeding_edge #

Patch Set 4 : nit merge issue fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -1210 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerListener.java View 2 chunks +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerListenerAdapter.java View 2 chunks +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindElementReferencesConsumer.java View 1 chunk +14 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindMemberDeclarationsConsumer.java View 1 chunk +9 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindMemberReferencesConsumer.java View 1 chunk +9 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindTopLevelDeclarationsConsumer.java View 1 chunk +9 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetTypeHierarchyConsumer.java View 2 chunks +11 lines, -3 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/SearchIdConsumer.java View 1 1 chunk +0 lines, -28 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/SearchResult.java View 1 chunk +0 lines, -61 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/SearchResultKind.java View 1 chunk +0 lines, -51 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/SearchResultsConsumer.java View 1 chunk +2 lines, -0 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/TypeHierarchyItem.java View 1 chunk +0 lines, -95 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/TypeHierarchyItem.java View 1 chunk +8 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/BroadcastAnalysisServerListener.java View 3 chunks +2 lines, -2 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/SearchResultImpl.java View 1 chunk +0 lines, -79 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/TypeHierarchyItemImpl.java View 1 chunk +0 lines, -112 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 1 2 10 chunks +46 lines, -103 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/FindElementReferencesProcessor.java View 1 2 1 chunk +11 lines, -7 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/FindMemberDeclarationsProcessor.java View 1 chunk +8 lines, -7 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/FindMemberReferencesProcessor.java View 1 chunk +8 lines, -9 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/FindTopLevelDeclarationsProcessor.java View 1 1 chunk +8 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationSearchResultsProcessor.java View 2 chunks +2 lines, -32 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/SearchIdProcessor.java View 1 1 chunk +0 lines, -38 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/TypeHierarchyProcessor.java View 2 chunks +5 lines, -65 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java View 2 chunks +1 line, -68 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServerListener.java View 1 2 2 chunks +2 lines, -1 line 0 comments Download
D editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/ElementImplTest.java View 1 chunk +0 lines, -191 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAll.java View 1 chunk +0 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java View 5 chunks +4 lines, -4 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TypeHierarchyItemImplTest.java View 1 chunk +0 lines, -61 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 1 2 11 chunks +99 lines, -119 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/model/SearchResultsListener.java View 2 chunks +4 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/SearchResultsSet.java View 1 chunk +5 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/elements/TopLevelElement_NEW.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/FindDeclarationsAction_NEW.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/FindReferencesAction_NEW.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/SearchResultPage_NEW.java View 2 chunks +7 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/typehierarchy/TypeHierarchyContentProvider_NEW.java View 6 chunks +33 lines, -28 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 2 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
LGTM https://codereview.chromium.org/542323003/diff/20001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindElementReferencesConsumer.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindElementReferencesConsumer.java (right): https://codereview.chromium.org/542323003/diff/20001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindElementReferencesConsumer.java#newcode19 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindElementReferencesConsumer.java:19: * The interface {@code FindElementReferencesConsumer} defines the behavior ...
6 years, 3 months ago (2014-09-06 17:52:42 UTC) #2
jwren
On 2014/09/06 17:52:42, scheglov wrote: > LGTM > > https://codereview.chromium.org/542323003/diff/20001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindElementReferencesConsumer.java > File > editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/FindElementReferencesConsumer.java > ...
6 years, 3 months ago (2014-09-08 04:40:02 UTC) #3
jwren
6 years, 3 months ago (2014-09-08 04:41:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 39949 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698