editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java - Issue 542323003: Search domain implementation in the Remote java server, using generated types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java

Issue 542323003: Search domain implementation in the Remote java server, using generated types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: nit merge issue fixed Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/model/SearchResultsListener.java ('k') | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/SearchResultsSet.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java

index 9d6a7253a196a9cd87c497e25f2a5e7411eaab1d..cbd4546ad808493c27d5e3ae2302f63803c13138 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java

@@ -20,7 +20,6 @@ import com.google.common.collect.Maps;

import com.google.common.collect.Sets;

import com.google.dart.engine.error.ErrorCode;

import com.google.dart.server.AnalysisServer;

-import com.google.dart.server.SearchResult;

import com.google.dart.server.generated.types.AnalysisError;

import com.google.dart.server.generated.types.AnalysisService;

import com.google.dart.server.generated.types.AnalysisStatus;

@@ -29,6 +28,7 @@ import com.google.dart.server.generated.types.NavigationRegion;

import com.google.dart.server.generated.types.Occurrences;

import com.google.dart.server.generated.types.Outline;

import com.google.dart.server.generated.types.OverrideMember;

+import com.google.dart.server.generated.types.SearchResult;

import com.google.dart.tools.core.analysis.model.AnalysisServerData;

import com.google.dart.tools.core.analysis.model.AnalysisServerHighlightsListener;

import com.google.dart.tools.core.analysis.model.AnalysisServerOutlineListener;

@@ -273,7 +273,7 @@ public class AnalysisServerDataImpl implements AnalysisServerData {

}

- synchronized void internalComputedSearchResults(String searchId, SearchResult[] results,

+ synchronized void internalComputedSearchResults(String searchId, List<SearchResult> results,

boolean last) {

SearchResultsListener listener = searchResultsListeners.get(searchId);

if (listener != null) {