Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2136)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java

Issue 542323003: Search domain implementation in the Remote java server, using generated types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: nit merge issue fixed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java
index 9d55a4cfb176a798aa0d253e6e96de5359a60fb1..6b8a02924509f8ed8bf8d13ba4c8ad51bc384c83 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java
@@ -60,12 +60,9 @@ public class RequestUtilities {
private static final String METHOD_ANALYSIS_UPDATE_OPTIONS = "analysis.updateOptions";
// Edit domain
- private static final String METHOD_EDIT_APPLY_REFACTORING = "edit.applyRefactoring";
- private static final String METHOD_EDIT_CREATE_REFACTORING = "edit.createRefactoring";
- private static final String METHOD_EDIT_DELETE_REFACTORING = "edit.deleteRefactoring";
private static final String METHOD_EDIT_GET_ASSISTS = "edit.getAssists";
- private static final String METHOD_EDIT_GET_FIXES = "edit.getFixes";
private static final String METHOD_EDIT_GET_AVAILABLE_REFACTORING = "edit.getAvailableRefactorings";
+ private static final String METHOD_EDIT_GET_FIXES = "edit.getFixes";
private static final String METHOD_EDIT_GET_REFACTORING = "edit.getRefactoring";
// Code Completion domain
@@ -312,70 +309,6 @@ public class RequestUtilities {
}
/**
- * Generate and return a {@value #METHOD_EDIT_APPLY_REFACTORING} request.
- *
- * <pre>
- * request: {
- * "id": String
- * "method": "edit.applyRefactoring"
- * "params": {
- * "id": RefactoringId
- * }
- * }
- * </pre>
- */
- public static JsonObject generateEditApplyRefactoring(String idValue, String refactoringId) {
- JsonObject params = new JsonObject();
- params.addProperty("id", refactoringId);
- return buildJsonObjectRequest(idValue, METHOD_EDIT_APPLY_REFACTORING, params);
- }
-
- /**
- * Generate and return a {@value #METHOD_EDIT_CREATE_REFACTORING} request.
- *
- * <pre>
- * request: {
- * "id": String
- * "method": "edit.createRefactoring"
- * "params": {
- * "kind": RefactoringKind
- * "file": FilePath
- * "offset": int
- * "length": int
- * }
- * }
- * </pre>
- */
- public static JsonObject generateEditCreateRefactoring(String idValue, String refactoringKind,
- String file, int offset, int length) {
- JsonObject params = new JsonObject();
- params.addProperty("kind", refactoringKind);
- params.addProperty(FILE, file);
- params.addProperty(OFFSET, offset);
- params.addProperty(LENGTH, length);
- return buildJsonObjectRequest(idValue, METHOD_EDIT_CREATE_REFACTORING, params);
- }
-
- /**
- * Generate and return a {@value #METHOD_EDIT_DELETE_REFACTORING} request.
- *
- * <pre>
- * request: {
- * "id": String
- * "method": "edit.deleteRefactoring"
- * "params": {
- * "id": RefactoringId
- * }
- * }
- * </pre>
- */
- public static JsonObject generateEditDeleteRefactoring(String idValue, String refactoringId) {
- JsonObject params = new JsonObject();
- params.addProperty("id", refactoringId);
- return buildJsonObjectRequest(idValue, METHOD_EDIT_DELETE_REFACTORING, params);
- }
-
- /**
* Generate and return a {@value #METHOD_EDIT_GET_ASSISTS} request.
*
* <pre>

Powered by Google App Engine
This is Rietveld 408576698