Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 541823004: Decode RefactoringFeedback automatically. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Decode RefactoringFeedback automatically. The implementation is pretty ugly though. 1. I have to add Response into ResponseDecoder. 2. I have to hack EditGetRefactoringParams.fromRequest generation to feel the "id to kind" map. It would be easier if we decided to return 'kind' in responses. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+530 lines, -179 lines) Patch
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractLocalVariableFeedback.java View 4 chunks +49 lines, -48 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodFeedback.java View 1 chunk +270 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringFeedback.java View 1 chunk +22 lines, -10 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameFeedback.java View 5 chunks +15 lines, -36 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 4 chunks +9 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 39 chunks +75 lines, -52 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 4 chunks +32 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 6 chunks +6 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 3 chunks +11 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 5 chunks +27 lines, -12 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-04 17:37:12 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-04 19:59:17 UTC) #2
scheglov
6 years, 3 months ago (2014-09-04 21:13:34 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 39887 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698