Decode RefactoringFeedback automatically.

pkg/analysis_server/tool/spec/codegen_dart_protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library codegen.protocol;
 
 import 'dart:convert';
 
 import 'api.dart';
 import 'codegen_tools.dart';
@@ skipping 274 matching lines @@
       ImpliedType impliedType) {
     docComment(toHtmlVisitor.collectHtml(() {
       toHtmlVisitor.p(() {
         toHtmlVisitor.write(impliedType.humanReadableName);
       });
       if (impliedType.type != null) {
         toHtmlVisitor.showType(null, impliedType.type);
       }
     }));
     write('class $className');
+    if (impliedType.kind == 'refactoringFeedback') {
+      write(' extends RefactoringFeedback');
+    }
     if (impliedType.kind == 'refactoringOptions') {
       write(' extends RefactoringOptions');
     }
     writeln(' implements HasToJson {');
     indent(() {
       if (emitSpecialStaticMembers(className)) {
         writeln();
       }
       for (TypeObjectField field in type.fields) {
         if (field.value != null) {
@@ skipping 656 matching lines @@
         "Don't know how to compare for equality: $resolvedType");
   }
 
   /**
    * Emit the method for decoding an object from JSON.
    */
   void emitObjectFromJsonConstructor(String className, TypeObject type,
       ImpliedType impliedType) {
     String humanReadableNameString =
         literalString(impliedType.humanReadableName);
+    if (className == 'RefactoringFeedback') {
+      writeln('factory RefactoringFeedback.fromJson(JsonDecoder jsonDecoder, '
+          'String jsonPath, Object json, Map responseJson) {');
+      indent(() {
+        writeln('return _refactoringFeedbackFromJson(jsonDecoder, jsonPath, '
+            'json, responseJson);');
+      });
+      writeln('}');
+      return;
+    }
     if (className == 'RefactoringOptions') {
       writeln('factory RefactoringOptions.fromJson(JsonDecoder jsonDecoder, '
           'String jsonPath, Object json, RefactoringKind kind) {');
       indent(() {
         writeln('return _refactoringOptionsFromJson(jsonDecoder, jsonPath, '
             'json, kind);');
       });
       writeln('}');
       return;
     }
@@ skipping 102 matching lines @@
    */
   FromJsonCode fromJsonCode(TypeDecl type) {
     if (type is TypeReference) {
       TypeDefinition referencedDefinition = api.types[type.typeName];
       if (referencedDefinition != null) {
         TypeDecl referencedType = referencedDefinition.type;
         if (referencedType is TypeObject || referencedType is TypeEnum) {
           return new FromJsonSnippet(
               (String jsonPath, String json) {
                 String typeName = dartType(type);
-                if (typeName == 'RefactoringOptions') {
+                if (typeName == 'RefactoringFeedback') {
+                  return 'new $typeName.fromJson(jsonDecoder, $jsonPath, $json, json)';
+                } else if (typeName == 'RefactoringOptions') {
                   return 'new $typeName.fromJson(jsonDecoder, $jsonPath, $json, kind)';
                 } else {
                   return 'new $typeName.fromJson(jsonDecoder, $jsonPath, $json)';
                 }
               });
         } else {
           return fromJsonCode(referencedType);
         }
       } else {
         switch (type.typeName) {
@@ skipping 92 matching lines @@
         inputType = 'Request';
         inputName = 'request';
         fieldName = '_params';
         makeDecoder = 'new RequestDecoder(request)';
         constructorName = 'fromRequest';
         break;
       case 'requestResult':
         inputType = 'Response';
         inputName = 'response';
         fieldName = '_result';
-        makeDecoder = 'new ResponseDecoder()';
+        makeDecoder = 'new ResponseDecoder(response)';
         constructorName = 'fromResponse';
         break;
       case 'notificationParams':
         inputType = 'Notification';
         inputName = 'notification';
         fieldName = '_params';
-        makeDecoder = 'new ResponseDecoder()';
+        makeDecoder = 'new ResponseDecoder(null)';
         constructorName = 'fromNotification';
         break;
-      case 'refactoringFeedback':
-        inputType = 'EditGetRefactoringResult';
-        inputName = 'refactoringResult';
-        fieldName = 'feedback';
-        makeDecoder = 'new ResponseDecoder()';
-        constructorName = 'fromRefactoringResult';
-        break;
       case 'refactoringOptions':
         inputType = 'EditGetRefactoringParams';
         inputName = 'refactoringParams';
         fieldName = 'options';
         makeDecoder = 'new RequestDecoder(request)';
         constructorName = 'fromRefactoringParams';
         extraArgs.add('Request request');
         break;
       default:
         return false;
     }
     List<String> args = ['$inputType $inputName'];
     args.addAll(extraArgs);
     writeln('factory $className.$constructorName(${args.join(', ')}) {');
     indent(() {
       String fieldNameString =
           literalString(fieldName.replaceFirst(new RegExp('^_'), ''));
-      writeln('return new $className.fromJson(');
-      writeln('    $makeDecoder, $fieldNameString, $inputName.$fieldName);');
+      if (className == 'EditGetRefactoringParams') {
+        writeln('var params = new $className.fromJson(');
+        writeln('    $makeDecoder, $fieldNameString, $inputName.$fieldName);');
+        writeln('REQUEST_ID_REFACTORING_KINDS[request.id] = params.kind;');
+        writeln('return params;');
+      } else {
+        writeln('return new $className.fromJson(');
+        writeln('    $makeDecoder, $fieldNameString, $inputName.$fieldName);');
+      }
     });
     writeln('}');
     return true;
   }
 
   /**
    * Create a string literal that evaluates to [s].
    */
   String literalString(String s) {
     return JSON.encode(s);
@@ skipping 34 matching lines @@
   CodegenProtocolVisitor visitor = new CodegenProtocolVisitor(readApi());
   return visitor.collectCode(visitor.visitApi);
 });
 
 /**
  * Translate spec_input.html into protocol_matchers.dart.
  */
 main() {
   target.generate();
 }