Decode RefactoringFeedback automatically.

pkg/analysis_server/test/edit/refactoring_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.edit.refactoring;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/edit/edit_domain.dart';
 import 'package:analysis_server/src/protocol.dart';
@@ skipping 102 matching lines @@
     addTestFile('''
 class TreeItem {}
 TreeItem getSelectedItem() => null;
 main() {
   var a = getSelectedItem();
 }
 ''');
     return getRefactoringResult(() {
       return sendStringSuffixRequest('getSelectedItem()', ';', null, true);
     }).then((result) {
-      ExtractLocalVariableFeedback feedback =
-          new ExtractLocalVariableFeedback.fromRefactoringResult(result);
+      ExtractLocalVariableFeedback feedback = result.feedback;
       expect(
           feedback.names,
           unorderedEquals(['treeItem', 'item', 'selectedItem']));
       expect(result.change, isNull);
     });
   }
 
   test_offsetsLengths() {
     addTestFile('''
 main() {
   print(1 + 2);
   print(1 +  2);
 }
 ''');
     return getRefactoringResult(() {
       return sendStringRequest('1 + 2', 'res', true);
     }).then((result) {
-      ExtractLocalVariableFeedback feedback =
-          new ExtractLocalVariableFeedback.fromRefactoringResult(result);
+      ExtractLocalVariableFeedback feedback = result.feedback;
       expect(feedback.offsets, [findOffset('1 + 2'), findOffset('1 +  2')]);
       expect(feedback.lengths, [5, 6]);
     });
   }
 }
 
 
 @ReflectiveTestCase()
 class ExtractMethodTest extends _AbstractGetRefactoring_Test {
   int offset;
@@ skipping 45 matching lines @@
     addTestFile('''
 main() {
   int a = 1;
   int b = 2;
   print(a + b);
   print(a + b);
 }
 ''');
     _setOffsetLengthForString('a + b');
     return getRefactoringResult(_computeChange).then((result) {
-      ExtractMethodFeedback feedback =
-          new ExtractMethodFeedback.fromRefactoringResult(result);
+      ExtractMethodFeedback feedback = result.feedback;
       List<RefactoringMethodParameter> parameters = feedback.parameters;
       parameters[0].name = 'aaa';
       parameters[1].name = 'bbb';
       parameters[1].type = 'num';
       parameters.insert(0, parameters.removeLast());
       options.parameters = parameters;
       return assertSuccessfulRefactoring(_sendExtractRequest, '''
 main() {
   int a = 1;
   int b = 2;
@@ skipping 72 matching lines @@
       // send request with the options
       return _sendExtractRequest();
     });
   }
 
   Future<ExtractMethodFeedback> _computeInitialFeedback() {
     return waitForTasksFinished().then((_) {
       return _sendExtractRequest();
     }).then((Response response) {
       var result = new EditGetRefactoringResult.fromResponse(response);
-      return new ExtractMethodFeedback.fromRefactoringResult(result);
+      return result.feedback;
     });
   }
 
   Future _prepareOptions() {
     return getRefactoringResult(() {
       // get initial feedback
       return _sendExtractRequest();
     }).then((result) {
       assertResultProblemsOK(result);
       // fill options from result
-      var feedback = new ExtractMethodFeedback.fromRefactoringResult(result);
+      ExtractMethodFeedback feedback = result.feedback;
       options = new ExtractMethodOptions(
           feedback.returnType,
           false,
           name,
           feedback.parameters,
           true);
       // done
       return new Future.value();
     });
   }
@@ skipping 535 matching lines @@
   test_feedback() {
     addTestFile('''
 class Test {}
 main() {
   Test v;
 }
 ''');
     return getRefactoringResult(() {
       return sendRenameRequest('st v;', 'NewName');
     }).then((result) {
-      RenameFeedback feedback =
-          new RenameFeedback.fromRefactoringResult(result);
+      RenameFeedback feedback = result.feedback;
       expect(feedback, isNotNull);
       expect(feedback.offset, findOffset('Test v;'));
       expect(feedback.length, 'Test'.length);
     });
   }
 
   test_function() {
     addTestFile('''
 test() {}
 main() {
@@ skipping 174 matching lines @@
   }
 
   @override
   void setUp() {
     super.setUp();
     server.handlers = [new EditDomainHandler(server),];
     createProject();
     handler = new EditDomainHandler(server);
   }
 }