Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 537733002: Use typed RefactoringOptions in the Dart version of the protocol. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Paul Berry, jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use typed RefactoringOptions in the Dart version of the protocol. R=jwren@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39875

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update also Java generator #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -332 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractLocalVariableOptions.java View 1 3 chunks +39 lines, -56 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java View 1 1 chunk +215 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/InlineMethodOptions.java View 1 3 chunks +39 lines, -39 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringOptions.java View 1 2 chunks +11 lines, -39 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameOptions.java View 1 3 chunks +27 lines, -27 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 1 3 chunks +3 lines, -3 lines 1 comment Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java View 1 2 chunks +4 lines, -53 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServer.java View 1 2 chunks +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 1 15 chunks +36 lines, -34 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 4 chunks +9 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 3 chunks +6 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 9 chunks +45 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 4 chunks +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 3 chunks +11 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 4 chunks +25 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 10 chunks +62 lines, -38 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
scheglov
6 years, 3 months ago (2014-09-03 21:15:04 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/537733002/diff/1/pkg/analysis_server/tool/spec/codegen_dart_protocol.dart File pkg/analysis_server/tool/spec/codegen_dart_protocol.dart (right): https://codereview.chromium.org/537733002/diff/1/pkg/analysis_server/tool/spec/codegen_dart_protocol.dart#newcode286 pkg/analysis_server/tool/spec/codegen_dart_protocol.dart:286: print(impliedType.kind); Was this temporary debug code? It looks ...
6 years, 3 months ago (2014-09-03 21:23:55 UTC) #2
scheglov
Paul and Jaime, PTAL. I updated also Java code generator to generate corresponding RefactoringOptions objects ...
6 years, 3 months ago (2014-09-04 01:37:18 UTC) #4
Paul Berry
lgtm https://codereview.chromium.org/537733002/diff/20001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java (right): https://codereview.chromium.org/537733002/diff/20001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java#newcode388 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java:388: // TODO (jwren) can options be Map<String, Object>? ...
6 years, 3 months ago (2014-09-04 14:43:05 UTC) #5
jwren
LGTM
6 years, 3 months ago (2014-09-04 16:18:28 UTC) #6
scheglov
6 years, 3 months ago (2014-09-04 16:21:18 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 39875 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698