Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringOptions.java

Issue 537733002: Use typed RefactoringOptions in the Dart version of the protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update also Java generator Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringOptions.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RemoveContentOverlay.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringOptions.java
similarity index 56%
copy from editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RemoveContentOverlay.java
copy to editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringOptions.java
index 72758a7f73900db530028bd06af695e70f3f10ed..97ef81c2c4cb12b1c583e61126ec132b1839cb4e 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RemoveContentOverlay.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringOptions.java
@@ -32,71 +32,45 @@ import java.util.Iterator;
import org.apache.commons.lang3.StringUtils;
/**
- * A directive to remove an existing file content overlay. After processing this directive, the
- * file contents will once again be read from the file system.
- *
- * If this directive is used on a file that doesn't currently have a content overlay, it has no
- * effect.
+ * An abstract superclass of all refactoring options.
*
* @coverage dart.server.generated.types
*/
@SuppressWarnings("unused")
-public class RemoveContentOverlay {
-
- public static final RemoveContentOverlay[] EMPTY_ARRAY = new RemoveContentOverlay[0];
+public class RefactoringOptions {
- public static final List<RemoveContentOverlay> EMPTY_LIST = Lists.newArrayList();
+ public static final RefactoringOptions[] EMPTY_ARRAY = new RefactoringOptions[0];
- private final String type;
+ public static final List<RefactoringOptions> EMPTY_LIST = Lists.newArrayList();
/**
- * Constructor for {@link RemoveContentOverlay}.
+ * Constructor for {@link RefactoringOptions}.
*/
- public RemoveContentOverlay() {
- this.type = "remove";
+ public RefactoringOptions() {
}
@Override
public boolean equals(Object obj) {
- if (obj instanceof RemoveContentOverlay) {
- RemoveContentOverlay other = (RemoveContentOverlay) obj;
+ if (obj instanceof RefactoringOptions) {
+ RefactoringOptions other = (RefactoringOptions) obj;
return
- ObjectUtilities.equals(other.type, type);
+ true;
}
return false;
}
- public static RemoveContentOverlay fromJson(JsonObject jsonObject) {
- String type = jsonObject.get("type").getAsString();
- return new RemoveContentOverlay();
- }
-
- public static List<RemoveContentOverlay> fromJsonArray(JsonArray jsonArray) {
- if (jsonArray == null) {
- return EMPTY_LIST;
- }
- ArrayList<RemoveContentOverlay> list = new ArrayList<RemoveContentOverlay>(jsonArray.size());
- Iterator<JsonElement> iterator = jsonArray.iterator();
- while (iterator.hasNext()) {
- list.add(fromJson(iterator.next().getAsJsonObject()));
- }
- return list;
- }
-
- public String getType() {
- return type;
+ public static RefactoringOptions fromJson(JsonObject jsonObject) {
+ return new RefactoringOptions();
}
@Override
public int hashCode() {
HashCodeBuilder builder = new HashCodeBuilder();
- builder.append(type);
return builder.toHashCode();
}
public JsonObject toJson() {
JsonObject jsonObject = new JsonObject();
- jsonObject.addProperty("type", type);
return jsonObject;
}
@@ -104,8 +78,6 @@ public class RemoveContentOverlay {
public String toString() {
StringBuilder builder = new StringBuilder();
builder.append("[");
- builder.append("type=");
- builder.append(type);
builder.append("]");
return builder.toString();
}

Powered by Google App Engine
This is Rietveld 408576698