editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java - Issue 537733002: Use typed RefactoringOptions in the Dart version of the protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java

Issue 537733002: Use typed RefactoringOptions in the Dart version of the protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update also Java generator Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameOptions.java ('k') | editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java

diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java

index a6492d02b869171e24266b161abe1c23ba124553..f88bdf37273810127777604e01fff66f7424683a 100644

--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java

+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java

@@ -38,6 +38,7 @@ import com.google.dart.server.GetVersionConsumer;

import com.google.dart.server.MapUriConsumer;

import com.google.dart.server.SearchIdConsumer;

import com.google.dart.server.generated.types.AnalysisOptions;

+import com.google.dart.server.generated.types.RefactoringOptions;

import com.google.dart.server.internal.BroadcastAnalysisServerListener;

import com.google.dart.server.internal.remote.processor.AnalysisErrorsProcessor;

import com.google.dart.server.internal.remote.processor.AssistsProcessor;

@@ -380,10 +381,9 @@ public class RemoteAnalysisServerImpl implements AnalysisServer {

sendRequestToServer(id, RequestUtilities.generateEditGetFixes(id, file, offset), consumer);

}

- @SuppressWarnings("unchecked")

@Override

public void edit_getRefactoring(String kindId, String file, Integer offset, Integer length,

- Boolean validateOnly, Object options, GetRefactoringConsumer consumer) {

+ Boolean validateOnly, RefactoringOptions options, GetRefactoringConsumer consumer) {

String id = generateUniqueId();

// TODO (jwren) can options be Map<String, Object>?

Paul Berry 2014/09/04 14:43:05 Remove this TODO.

sendRequestToServer(id, RequestUtilities.generateEditGetRefactoring(

@@ -393,7 +393,7 @@ public class RemoteAnalysisServerImpl implements AnalysisServer {

offset,

length,

validateOnly,

- (Map<String, Object>) options), consumer);

+ options), consumer);

}

public void findElementReferences(String file, int offset, boolean includePotential,