Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 509563004: Give instances their own model class; move DartErrors out of instance-ref into their own error-ref. (Closed)

Created:
6 years, 3 months ago by rmacnak
Modified:
6 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Give instances their own model class; move DartErrors out of instance-ref into their own error-ref. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39682

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : #

Patch Set 6 : build #

Patch Set 7 : rebase and build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4002 lines, -3229 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html View 1 2 3 4 5 6 19 chunks +341 lines, -76 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html._data View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 5 6 488 chunks +1494 lines, -1403 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 1 2 3 4 5 6 19 chunks +341 lines, -76 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html._data View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 5 6 488 chunks +1494 lines, -1403 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 3 4 5 6 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/code_view.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/error_ref.html View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/eval_box.html View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/eval_link.html View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/field_view.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 2 3 4 5 6 2 chunks +16 lines, -30 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 3 4 5 6 6 chunks +31 lines, -32 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/library_view.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/stack_frame.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/boot.js View 1 2 3 4 5 6 1 chunk +1 line, -6 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/build.log View 1 2 3 4 5 6 1 chunk +16 lines, -13 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/polymer.js View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
A + runtime/bin/vmservice/observatory/deployed/web/packages/unittest/coverage_controller.js View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/observatory/deployed/web/packages/unittest/test_controller.js View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/build.log View 1 2 3 4 5 6 1 chunk +31 lines, -22 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js View 1 2 3 4 5 6 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/class_view.html View 6 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/code_view.html View 6 1 chunk +1 line, -1 line 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/error_ref.dart View 6 1 chunk +14 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/error_ref.html View 6 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/error_view.dart View 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/eval_box.html View 6 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/eval_link.html View 6 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/field_view.html View 1 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.dart View 1 6 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html View 1 2 3 4 5 6 2 chunks +16 lines, -30 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_view.dart View 1 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/instance_view.html View 1 2 3 4 6 6 chunks +31 lines, -32 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/library_view.html View 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart View 1 2 3 4 6 1 chunk +0 lines, -60 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart View 1 2 3 4 6 3 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/stack_frame.html View 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 1 2 3 4 5 6 5 chunks +75 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
rmacnak@google.com changed reviewers: + johnmccutchan@google.com
6 years, 3 months ago (2014-08-28 00:47:04 UTC) #1
rmacnak
6 years, 3 months ago (2014-08-28 00:47:04 UTC) #2
Cutch
https://codereview.chromium.org/509563004/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart File runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart (right): https://codereview.chromium.org/509563004/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart#newcode14 runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart:14: @published ObservableMap ref; ServiceMap https://codereview.chromium.org/509563004/diff/60001/runtime/bin/vmservice/observatory/lib/src/service/object.dart File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/509563004/diff/60001/runtime/bin/vmservice/observatory/lib/src/service/object.dart#newcode46 ...
6 years, 3 months ago (2014-08-28 14:46:06 UTC) #3
rmacnak
https://codereview.chromium.org/509563004/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart File runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart (right): https://codereview.chromium.org/509563004/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart#newcode14 runtime/bin/vmservice/observatory/lib/src/elements/inbound_reference.dart:14: @published ObservableMap ref; On 2014/08/28 14:46:05, Cutch wrote: > ...
6 years, 3 months ago (2014-08-28 19:41:06 UTC) #4
Cutch
lgtm
6 years, 3 months ago (2014-08-28 20:58:36 UTC) #5
rmacnak
6 years, 3 months ago (2014-08-28 21:56:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #7 (id:110001) manually as 39682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698