runtime/bin/vmservice/observatory/lib/src/elements/class_view.html - Issue 509563004: Give instances their own model class; move DartErrors out of instance-ref into their own error-ref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/class_view.html

Issue 509563004: Give instances their own model class; move DartErrors out of instance-ref into their own error-ref. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase and build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js ('k') | runtime/bin/vmservice/observatory/lib/src/elements/code_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/class_view.html

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/class_view.html b/runtime/bin/vmservice/observatory/lib/src/elements/class_view.html

index de1e0a458e1a9e0906956bf44d1f81c3b40dcec4..5b0386780c0a9adbd4b3d1d899b94551202fe880 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/class_view.html

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/class_view.html

@@ -92,8 +92,7 @@

</div>

-

- <instance-ref ref="{{ cls.error }}"></instance-ref>

+ <error-ref ref="{{ cls.error }}"></error>

</template>

<hr>

@@ -110,7 +109,7 @@

</div>

- <instance-ref ref="{{ field['value'] }}"></instance-ref>

+ <any-service-ref ref="{{ field['value'] }}"></any-service-ref>

</template>

</div>

@@ -155,7 +154,7 @@

</template>

sample

- <instance-ref ref="{{ instances['sample'] }}"></instance-ref>

+ <any-service-ref ref="{{ instances['sample'] }}"></any-service-ref>

<template if="{{ instances['totalCount'] > instances['sampleCount'] }}">

<eval-link callback="{{ reachable }}"

label="[more]"